[Libreoffice-commits] core.git: Branch 'feature/priorities' - include/vcl vcl/source

[Miklos Vajna]

On Thu, Jan 22, 2015 at 10:58:13AM +0100, Tobias Madl <tobias.madl.dev at gmail.com> wrote:
> But i don't get the thing with changing it to a C++11 enum class. It is
> already an enum class ????

In your feature branch, you have:

>  enum class IdlePriority {

That's a C++11 enum class.

On master, it's:

> enum IdlePriority {

That's why I said -- if you change it to an enum class and you need to
adjust all client code anyway, then I would also drop the now redundant
prefixes as well. See 22f0862ae782c90306d444d2f5aa253b9e97acd2 for
example or 5333782d090a9e147c0c431f0f741863d1d8cf8e.

Regards,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150122/f9ccab2d/attachment.sig>