[Libreoffice-commits] core.git: Branch 'feature/priorities' - include/vcl vcl/source

Tobias Madl tobias.madl.dev at gmail.com
Thu Jan 22 06:24:09 PST 2015


Removed the Prefix :)

2dc1136e2287b52ba3c3c58a1d70de78ad53fef7

Cheers

Tobi

On Thu, Jan 22, 2015 at 12:14 PM, Miklos Vajna <vmiklos at collabora.co.uk>
wrote:

> On Thu, Jan 22, 2015 at 10:58:13AM +0100, Tobias Madl <
> tobias.madl.dev at gmail.com> wrote:
> > But i don't get the thing with changing it to a C++11 enum class. It is
> > already an enum class ????
>
> In your feature branch, you have:
>
> >  enum class IdlePriority {
>
> That's a C++11 enum class.
>
> On master, it's:
>
> > enum IdlePriority {
>
> That's why I said -- if you change it to an enum class and you need to
> adjust all client code anyway, then I would also drop the now redundant
> prefixes as well. See 22f0862ae782c90306d444d2f5aa253b9e97acd2 for
> example or 5333782d090a9e147c0c431f0f741863d1d8cf8e.
>
> Regards,
>
> Miklos
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150122/26e0b731/attachment.html>


More information about the LibreOffice mailing list