[Libreoffice-commits] core.git: Changes to 'private/jmux/multi-index-5-1'

[Miklos Vajna]

Hi Jan-Marek,

On Wed, Jun 17, 2015 at 06:17:35PM -0700, Jan-Marek Glogowski <glogow at fbihome.de> wrote:
> New branch 'private/jmux/multi-index-5-1' available with the following commits:
> commit e7a0b9e3d2699a7dd5aa1970985422c6b727a661
> Author: Jan-Marek Glogowski <glogow at fbihome.de>
> Date:   Fri Apr 10 21:32:36 2015 +0200
> 
>     Convert SwFrameFormat to boost::multi_index

Oh, this sounds nice! :-)

One nitpick: please avoid namespace aliases or using statements in
headers[1], currently ~no code does that (com::sun::star -> css is the
only exception, I think), and it helps readability: that way you can
always go to the start of the file and see all of them.

Just mentioning as I guess this affects each class where you add
multi-index support, so it saves time if you get this right from the
very beginning.

Thanks,

Miklos

[1] https://wiki.openoffice.org/wiki/Writer/Code_Conventions says
"header files, where using-statements are not permitted", AFAIK that's
still true for LO code, too
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150618/b9a48cb3/attachment.sig>