[Bug 90290] reduce some copy&paste code in ucalc

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Tue Mar 31 08:41:16 PDT 2015


--- Comment #7 from Kohei Yoshida <libreoffice at kohei.us> ---
BTW, just to mention this for the record, I did this type

if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
    CPPUNIT_FAIL("Wrong formula!");

of checks so that when it fails, you can get the line number of where the check
actually fails.  One disadvantage of writing a common function for this is that
when the check fails, the line number now points where inside that shared
function, not where it was called, and then you'd have to do some hunting to
see which check actually failed in what test case.

I'm not saying "don't do it", but I'm simply saying there is a thought behind
it, and there is a disadvantage to "cleaning it up".

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150331/9a29de07/attachment.html>

More information about the LibreOffice mailing list