Problem in Bug 93240
ashnakash at gmail.com
Tue Sep 1 10:50:49 PDT 2015
On Tue, Sep 1, 2015 at 11:50 AM, Shreyansh Gandhi <gandhishrey at gmail.com>
> Hey, I don't understand the reason why the build failed. Can you please
> take a look?
Looks like a Jenkins issue. Other builds have failed as well.
Rebase to rebuild again later when Jenkins shows some successful builds.
> On Tue, Sep 1, 2015 at 8:06 PM Michael Stahl <mstahl at redhat.com> wrote:
>> On 01.09.2015 15:34, Shreyansh Gandhi wrote:
>> > I just came across
>> > this:
>> > Will it be safe to use this method to push_back into m_Selectors?
>> yes, if it was pushing to a boost::ptr_container before (and we can
>> assume that that works), then converting it to a unique_ptr only at the
>> place when it is pushed is doing exactly the same thing.
>> the only problem to watch out for, if you do it earlier and convert a
>> variable declaration to std::unique_ptr then std::move into the
>> container then the variable contains a null pointer now - but if you
>> convert the bare pointer only inside the push_back call then this
>> problem is avoided.
>> LibreOffice mailing list
>> LibreOffice at lists.freedesktop.org
> Shreyansh Gandhi
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the LibreOffice