New Defects reported by Coverity Scan for LibreOffice
scan-admin at coverity.com
scan-admin at coverity.com
Thu Aug 18 13:44:14 UTC 2016
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
600 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 600 defect(s)
** CID 1371317: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/svtools/source/control/collatorres.cxx: 29 in ()
________________________________________________________________________________________________________
*** CID 1371317: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/svtools/source/control/collatorres.cxx: 29 in ()
23 #include <svtools/collatorres.hxx>
24
25
26 // wrapper for locale specific translations data of collator algorithm
27
28
>>> CID 1371317: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "CollatorResourceData" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
29 class CollatorResourceData
30 {
31 friend class CollatorResource;
32 private: /* data */
33 OUString ma_Name;
34 OUString ma_Translation;
** CID 1371316: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/lotuswordpro/source/filter/lwpcolor.hxx: 70 in ()
________________________________________________________________________________________________________
*** CID 1371316: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/lotuswordpro/source/filter/lwpcolor.hxx: 70 in ()
64 #include "lwpobjstrm.hxx"
65 #include "lwpheader.hxx"
66 /**
67 * @brief lwpcolor class
68 * (red, green, blue, extra)
69 */
>>> CID 1371316: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "LwpColor" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
70 class LwpColor
71 {
72 public:
73 LwpColor():m_nRed(0), m_nGreen(0), m_nBlue(0), m_nExtra(0){}
74 ~LwpColor(){}
75 public:
** CID 1371315: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/strokeattribute.hxx: 39 in ()
________________________________________________________________________________________________________
*** CID 1371315: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/strokeattribute.hxx: 39 in ()
33
34
35 namespace drawinglayer
36 {
37 namespace attribute
38 {
>>> CID 1371315: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "drawinglayer::attribute::StrokeAttribute" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
39 class DRAWINGLAYER_DLLPUBLIC StrokeAttribute
40 {
41 public:
42 typedef o3tl::cow_wrapper< ImpStrokeAttribute > ImplType;
43
44 private:
** CID 1371314: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/cppu/source/uno/lbmap.cxx: 58 in ()
________________________________________________________________________________________________________
*** CID 1371314: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/cppu/source/uno/lbmap.cxx: 58 in ()
52 using ::rtl::OUStringBuffer;
53 using ::rtl::OUStringHash;
54
55 namespace cppu
56 {
57
>>> CID 1371314: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "cppu::Mapping" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
58 class Mapping
59 {
60 uno_Mapping * _pMapping;
61
62 public:
63 inline explicit Mapping( uno_Mapping * pMapping = nullptr );
** CID 1371313: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/unotools/confignode.hxx: 46 in ()
________________________________________________________________________________________________________
*** CID 1371313: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/unotools/confignode.hxx: 46 in ()
40
41 class OConfigurationTreeRoot;
42 /** a small wrapper around a configuration node.<p/>
43 Nodes in the terminology used herein are <em>inner</em> nodes of a configuration
44 tree, which means <em>no leafs</em>.
45 */
>>> CID 1371313: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "utl::OConfigurationNode" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
46 class UNOTOOLS_DLLPUBLIC OConfigurationNode : public ::utl::OEventListenerAdapter
47 {
48 private:
49 css::uno::Reference< css::container::XHierarchicalNameAccess >
50 m_xHierarchyAccess; /// accessing children grandchildren (mandatory interface of our UNO object)
51 css::uno::Reference< css::container::XNameAccess >
** CID 1371312: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svtools/transfer.hxx: 266 in ()
________________________________________________________________________________________________________
*** CID 1371312: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svtools/transfer.hxx: 266 in ()
260
261 virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& rId ) throw( css::uno::RuntimeException, std::exception ) override;
262 };
263
264 struct TransferableDataHelper_Impl;
265
>>> CID 1371312: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "TransferableDataHelper" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
266 class SVT_DLLPUBLIC TransferableDataHelper
267 {
268 friend class DropTargetHelper;
269
270 private:
271
** CID 1371311: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sc/inc/docoptio.hxx: 33 in ()
________________________________________________________________________________________________________
*** CID 1371311: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sc/inc/docoptio.hxx: 33 in ()
27 #include "scdllapi.h"
28 #include "scmod.hxx"
29 #include "optutil.hxx"
30
31 #include <formula/grammar.hxx>
32
>>> CID 1371311: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "ScDocOptions" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
33 class SC_DLLPUBLIC ScDocOptions
34 {
35 double fIterEps; // epsilon value dazu
36 sal_uInt16 nIterCount; ///< number
37 sal_uInt16 nPrecStandardFormat; ///< precision for standard format
38 sal_uInt16 nDay; ///< Null date:
** CID 1371310: Incorrect expression (MIXED_ENUMS)
/cui/source/tabpages/chardlg.cxx: 3007 in SvxCharPositionPage::Reset(const SfxItemSet *)()
________________________________________________________________________________________________________
*** CID 1371310: Incorrect expression (MIXED_ENUMS)
/cui/source/tabpages/chardlg.cxx: 3007 in SvxCharPositionPage::Reset(const SfxItemSet *)()
3001 nWhich = GetWhich( SID_ATTR_CHAR_KERNING );
3002
3003 if ( rSet->GetItemState( nWhich ) >= SfxItemState::DEFAULT )
3004 {
3005 const SvxKerningItem& rItem = static_cast<const SvxKerningItem&>(rSet->Get( nWhich ));
3006 SfxMapUnit eUnit = rSet->GetPool()->GetMetric( nWhich );
>>> CID 1371310: Incorrect expression (MIXED_ENUMS)
>>> Mixing enum types "MapUnit" and "SfxMapUnit" for "eOrgUnit".
3007 MapUnit eOrgUnit = (MapUnit)eUnit;
3008 MapUnit ePntUnit( MAP_POINT );
3009 long nBig = static_cast<long>(m_pKerningMF->Normalize( static_cast<long>(rItem.GetValue()) ));
3010 long nKerning = LogicToLogic( nBig, eOrgUnit, ePntUnit );
3011
3012 // set Kerning at the Font, convert into Twips before
** CID 1371309: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/sdrlineattribute.hxx: 45 in ()
________________________________________________________________________________________________________
*** CID 1371309: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/sdrlineattribute.hxx: 45 in ()
39
40
41 namespace drawinglayer
42 {
43 namespace attribute
44 {
>>> CID 1371309: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "drawinglayer::attribute::SdrLineAttribute" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
45 class DRAWINGLAYER_DLLPUBLIC SdrLineAttribute
46 {
47 public:
48 typedef o3tl::cow_wrapper< ImpSdrLineAttribute > ImplType;
49
50 private:
** CID 1371308: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLException.hdl: 16 in ()
________________________________________________________________________________________________________
*** CID 1371308: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLException.hdl: 16 in ()
10 #include "sal/types.h"
11
12 namespace com { namespace sun { namespace star { namespace uno { class Type; } } } }
13
14 namespace com { namespace sun { namespace star { namespace sdbc {
15
>>> CID 1371308: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "com::sun::star::sdbc::SQLException" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
16 class CPPU_GCC_DLLPUBLIC_EXPORT SQLException : public ::css::uno::Exception
17 {
18 public:
19 inline CPPU_GCC_DLLPRIVATE SQLException();
20
21 inline CPPU_GCC_DLLPRIVATE SQLException(const ::rtl::OUString& Message_, const ::css::uno::Reference< ::css::uno::XInterface >& Context_, const ::rtl::OUString& SQLState_, const ::sal_Int32& ErrorCode_, const ::css::uno::Any& NextException_);
** CID 1371307: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/binaryurp/source/binaryany.hxx: 33 in ()
________________________________________________________________________________________________________
*** CID 1371307: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/binaryurp/source/binaryany.hxx: 33 in ()
27 namespace com { namespace sun { namespace star { namespace uno {
28 class TypeDescription;
29 } } } }
30
31 namespace binaryurp {
32
>>> CID 1371307: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "binaryurp::BinaryAny" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
33 class BinaryAny {
34 public:
35 BinaryAny() throw ();
36
37 BinaryAny(com::sun::star::uno::TypeDescription const & type, void * value)
38 throw ();
** CID 1371306: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/registry/registry.hxx: 83 in ()
________________________________________________________________________________________________________
*** CID 1371306: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/registry/registry.hxx: 83 in ()
77
78
79 /** The Registry provides the functionality to read and write information in a registry file.
80
81 The class is implemented inline and use a C-Api.
82 */
>>> CID 1371306: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "Registry" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
83 class Registry
84 {
85 public:
86 /** Default constructor.
87 */
88 inline Registry();
** CID 1371305: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svtools/grfmgr.hxx: 167 in ()
________________________________________________________________________________________________________
*** CID 1371305: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svtools/grfmgr.hxx: 167 in ()
161 {
162 return( mnLumPercent != 0 || mnContPercent != 0 || mnRPercent != 0 ||
163 mnGPercent != 0 || mnBPercent != 0 || mfGamma != 1.0 || mbInvert );
164 }
165 };
166
>>> CID 1371305: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "GraphicObject" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
167 class SVT_DLLPUBLIC GraphicObject : public SvDataCopyStream
168 {
169 friend class GraphicManager;
170 friend class SdrGrafObj;
171
172 private:
** CID 1371290: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLWarning.hdl: 13 in ()
________________________________________________________________________________________________________
*** CID 1371290: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLWarning.hdl: 13 in ()
7 #include "cppu/macros.hxx"
8
9 namespace com { namespace sun { namespace star { namespace uno { class Type; } } } }
10
11 namespace com { namespace sun { namespace star { namespace sdbc {
12
>>> CID 1371290: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "com::sun::star::sdbc::SQLWarning" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
13 class CPPU_GCC_DLLPUBLIC_EXPORT SQLWarning : public ::css::sdbc::SQLException
14 {
15 public:
16 inline CPPU_GCC_DLLPRIVATE SQLWarning();
17
18 inline CPPU_GCC_DLLPRIVATE SQLWarning(const ::rtl::OUString& Message_, const ::css::uno::Reference< ::css::uno::XInterface >& Context_, const ::rtl::OUString& SQLState_, const ::sal_Int32& ErrorCode_, const ::css::uno::Any& NextException_);
** CID 1371289: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/ustrbuf.hxx: 56 in ()
________________________________________________________________________________________________________
*** CID 1371289: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/ustrbuf.hxx: 56 in ()
50 #ifdef RTL_STRING_UNITTEST
51 #undef rtl
52 #endif
53
54 /** A string buffer implements a mutable sequence of characters.
55 */
>>> CID 1371289: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "rtl::OUStringBuffer" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
56 class SAL_WARN_UNUSED OUStringBuffer
57 {
58 public:
59 /**
60 Constructs a string buffer with no characters in it and an
61 initial capacity of 16 characters.
** CID 1371288: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/fillhatchattribute.hxx: 56 in ()
________________________________________________________________________________________________________
*** CID 1371288: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/fillhatchattribute.hxx: 56 in ()
50
51
52 namespace drawinglayer
53 {
54 namespace attribute
55 {
>>> CID 1371288: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "drawinglayer::attribute::FillHatchAttribute" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
56 class DRAWINGLAYER_DLLPUBLIC FillHatchAttribute
57 {
58 public:
59 typedef o3tl::cow_wrapper< ImpFillHatchAttribute > ImplType;
60
61 private:
** CID 1371287: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/strbuf.hxx: 61 in ()
________________________________________________________________________________________________________
*** CID 1371287: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/strbuf.hxx: 61 in ()
55 #define RTL_STRING_CONST_FUNCTION
56 #endif
57 /// @endcond
58
59 /** A string buffer implements a mutable sequence of characters.
60 */
>>> CID 1371287: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "rtl::OStringBuffer" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
61 class SAL_WARN_UNUSED OStringBuffer
62 {
63 public:
64 /**
65 Constructs a string buffer with no characters in it and an
66 initial capacity of 16 characters.
** CID 1371286: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/osl/socket_decl.hxx: 166 in ()
________________________________________________________________________________________________________
*** CID 1371286: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/osl/socket_decl.hxx: 166 in ()
160 static inline sal_Int32 SAL_CALL getServicePort(
161 const ::rtl::OUString& strServiceName,
162 const ::rtl::OUString & strProtocolName= ::rtl::OUString("tcp") );
163 };
164
165
>>> CID 1371286: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "osl::Socket" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
166 class Socket
167 {
168 protected:
169 oslSocket m_handle;
170 protected:
171 /** Creates a socket. Note it's protected.
** CID 1371285: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/basegfx/matrix/b3dhommatrix.hxx: 34 in ()
________________________________________________________________________________________________________
*** CID 1371285: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/basegfx/matrix/b3dhommatrix.hxx: 34 in ()
28
29 namespace basegfx
30 {
31 class B3DTuple;
32 class Impl3DHomMatrix;
33
>>> CID 1371285: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "basegfx::B3DHomMatrix" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
34 class BASEGFX_DLLPUBLIC B3DHomMatrix
35 {
36 public:
37 typedef o3tl::cow_wrapper< Impl3DHomMatrix, o3tl::ThreadSafeRefCountingPolicy > ImplType;
38
39 private:
** CID 1371284: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/sdrlinestartendattribute.hxx: 42 in ()
________________________________________________________________________________________________________
*** CID 1371284: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/sdrlinestartendattribute.hxx: 42 in ()
36
37
38 namespace drawinglayer
39 {
40 namespace attribute
41 {
>>> CID 1371284: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "drawinglayer::attribute::SdrLineStartEndAttribute" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
42 class DRAWINGLAYER_DLLPUBLIC SdrLineStartEndAttribute
43 {
44 public:
45 typedef o3tl::cow_wrapper< ImpSdrLineStartEndAttribute > ImplType;
46
47 private:
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyQ88RI-2BoKyiDEeVUuS8H6XQ0FnDjgZ3YOo7OWKLfHaOSPpxzwf9AZNYOzeJXu-2ByxMyw1Bkj4NlsxVHVMJyu6ss1clY2IbzmIwIKCQMTjUGoaAcYPqyZKjlx4zi1N6U5hcoOCFcNvJPLoQdaeG7DdWNlQweE7eu3ynBsjAdbOJxZs-3D
To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyQ88RI-2BoKyiDEeVUuS8H6XfpspVpxN9DFqZw1XODL-2FV1lgcxxw7-2FpHG3rQJy7XpWemI9GvJWEM23dEvUh6iN9lR5pYQwCdIeQtWzAuGAfff5BNysdaLpCr6sTLnT42tszXlboaaKD6rkQuWdxp-2F9U1LxIm6mwySd7G89LzETWmZ4-3D
More information about the LibreOffice
mailing list