tdf#96482 (5.0.4 regression introduced in fix of tdf#94069) [was: minutes of ESC call ...]

[Lionel Elie Mamane]

On Mon, Jan 25, 2016 at 04:49:43PM +0000, Caolán McNamara wrote:
> On Tue, 2016-01-05 at 14:05 +0100, Lionel Elie Mamane wrote:
> > On Thu, Dec 17, 2015 at 05:18:05PM +0000, Michael Meeks wrote:
> > 
> > >     + 5.0.4 - released as final today.
> > >         + dbaccess / table control columns editing - not delayed
> > > for it.
> > >             + fix lost in the sea of master; needs to be identified
> > > and cherry-picked into 5.0.5
> > 
> > Caolan, as mentioned in
> > https://bugs.documentfoundation.org/show_bug.cgi?id=96482#c5
> > I think you have the best clue which commit in "the sea of master" is
> > involved here.
> > 
> > Are you / will you be on it?
> 
> So, some bisecting shows that its 
> 
> commit 87199d3829257420429057336283c55be6ae7481
> Author: Michael Meeks <michael.meeks at collabora.com>
> Date:   Tue Nov 24 16:59:29 2015 +0000
> 
>     vcl: re-introduce idle handling.
> 
> which fixed the problem on master/5-1. Its non-trivial to backport that
> though to 5-0. Not sure how that should look if applied to 5-0

Well, IMO either we backport it to 5-0 (Michael?), or we abandon
fixing tdf#96482 in 5.0.x and declare the 5.0.x line "dead" for people
that design forms with table controls (be it in Base, in Writer or in
Calc). We could instead reintroduce tdf#94069, but since that's a
hang, I'll consider it a worse bug.

Since we now have a "LibreOffice Fresh" out with both bugs fixed,
that's not *completely* unacceptable, albeit sucks.

-- 
Lionel