Pushing to LibO-5-2

[jan iversen]

> On 21 Jun 2016, at 13:03, Christian Lohmaier <lohmaier at googlemail.com> wrote:
> 
> On Sun, Jun 19, 2016 at 9:07 AM, jan iversen
> <jani at documentfoundation.org> wrote:
>> 
>> As a new committer (thanks again for your confidence), I don't know yet all
>> the rules and I prefer to ask before breaking something.
>> 
>> Asking is clearly better than breaking :-)
>> 
>> As it is for 5-2 branch, do they require review from someone else than me,
>> before they can be pushed? (commits were already reviewed for master by jan)
>> 
>> Our review rules are described here (and how to add a patch to a branch):
>> https://wiki.documentfoundation.org/Development/Branches
>> Your patches are fixes to a X-Y branch, so no further review required.
> 
> Only in beta phase does a x-y branch not require review. after that it
> needs one review.

Maybe the text should be corrected in our wiki:
No review required until the last beta

which I read as no extra review is needed for a X-Y branch.

> And as Stephan pointed out: Only bugfixes go in.
And since this is a bugfix it should not be a problem ?

rgds
jan I.

> 
> ciao
> Christian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20160621/e7bef81e/attachment.html>