Proposal for using std::unique_ptr to signal transfer of ownership

Markus Mohrhard markus.mohrhard at
Fri Mar 11 08:20:50 UTC 2016


so while looking through some of the current calc memory leaks I noticed
that at least some of them are related to our poor API and I noticed that
quite a few of the problems can easily be avoided with better API design.

For now I would like to propose that we try to use std::unique_ptr in two
places to show ownership of data. A method that returns an object for which
ownership transfers to the caller we should return the object wrapped in a
std::unique_ptr. The same should be done for a method taking ownership of a

I hope that these are not really controversial and I'm aware that they are
not yet useful for all the old code but we need to start somewhere. Also if
there is some agreement on this there are some simple easy hacks that can
be done to move at least a bit of our code into this direction (e.g. the
horrible SfxItemPool::Clone method that results in quite a few of my leaks.)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the LibreOffice mailing list