clang -Wimplicit-fallthrough and missing breaks
tml at iki.fi
Wed May 25 07:01:56 UTC 2016
> --- a/vcl/opengl/win/gdiimpl.cxx
>> +++ b/vcl/opengl/win/gdiimpl.cxx
>> @@ -166,6 +166,7 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT
>> message, WPARAM wParam, LPARAM l
>> case VK_SPACE:
>> + SAL_FALLTHROUGH; //TODO ???
>> return DefWindowProc(hwnd, message, wParam, lParam);
I did not write this code, but looking at it, it seems fairly obvious that
the fall-through is intentional here. But it is beyond my understanding why
such a temporary window, that is used only for some milliseconds, and never
even displayed, would need to handle the Escape and Space keys specially.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the LibreOffice