clang -Wimplicit-fallthrough and missing breaks

[Tor Lillqvist]

> --- a/vcl/opengl/win/gdiimpl.cxx
>> +++ b/vcl/opengl/win/gdiimpl.cxx
>> @@ -166,6 +166,7 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT
>> message, WPARAM wParam, LPARAM l
>>          case VK_SPACE:
>>              break;
>>          }
>> +        SAL_FALLTHROUGH; //TODO ???
>>      default:
>>          return DefWindowProc(hwnd, message, wParam, lParam);
>>      }
>>
>
I did not write this code, but looking at it, it seems fairly obvious that
the fall-through is intentional here. But it is beyond my understanding why
such a temporary window, that is used only for some milliseconds, and never
even displayed, would need to handle the Escape and Space keys specially.

--tml
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20160525/42dcf7d4/attachment.html>