Let failed Jenkins builds set Verified: -1 in Gerrit?

Eike Rathke erack at redhat.com
Thu Dec 7 20:04:20 UTC 2017


Hi,

On Friday, 2017-12-01 11:27:02 -0600, Norbert Thiebaud wrote:

> On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky <d.ostrovsky at gmx.de> wrote:
> > On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote:
> >>Does "(with a help of maintainers)" imply that there are change
> >>owners who could not override a VRFY-1 from Jenkins themselves?
> >
> > Yes. I believe that "registered users" group members will not be
> > able to remove VRFY-1 vote.
> 
> I do not know of anyway, anyone can remove it using the ui, short of
> impersonating jenkins' user.
> 
> the only available way to remove the -1 is to rebase the patch, since
> hte -1 is bound to the particular patcheset version...
> then hope that jenkins will not put another -1, or at least quickly
> +2/+1 the rebased patch and submit... neither are desirable.
> 
> hence the choice of +1/0 rather than +1/-1 for jenkins.

Wouldn't it be possible to have the Verify field be a set of -2/-1/0/+1,
with -2 being the sticky denial value, and let Jenkins set only -1 or +1?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20171207/b9733fba/attachment.sig>


More information about the LibreOffice mailing list