What is the best way to pass a flag from a unit test?

Khaled Hosny khaledhosny at eglug.org
Wed Feb 1 21:57:11 UTC 2017


On Wed, Feb 01, 2017 at 10:41:33AM +0100, Miklos Vajna wrote:
> Hi Khaled,
> 
> On Wed, Feb 01, 2017 at 09:38:02AM +0200, Khaled Hosny <khaledhosny at eglug.org> wrote:
> > What the best way to detect, inside VCL, that a given CppunitTest is
> > being run and do something conditionally? I basically want to detect if
> > a given class of unit tests is run and disable all font searching and
> > fallback and just use a hard-coded font name so that the tests are not
> > affected by what fonts are available or not on the system (or that the
> > theory).
> 
> At one place vcl code already checks for LO_TESTNAME.
>
> (That may be a better option compared to the one in the comment of
> <https://gerrit.libreoffice.org/#/c/33775>.)

It seems that LO_TESTNAME name is currently not set on Windows (or that
is my reading of sal/cppunittester/cppunittester.cxx).

I’m rather not sure if we want to do this unconditionally for all tests
or not, but if that is the consensus, I think we can make sure
LO_TESTNAME is set also on Windows (assuming there is no reason not to
do so) and use it.

Regards,
Khaled
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20170201/1b7595cc/attachment.sig>


More information about the LibreOffice mailing list