Gerrit prevents upstreaming patches from others

Paul Menzel pmenzel+libreoffice at molgen.mpg.de
Mon Feb 6 11:07:33 UTC 2017


Dear Jan,


On 02/06/17 12:00, jan iversen wrote:

>> Sorry, I still don’t see where the additional step is?
>
> you submit the patch to gerrit, that does not put it into our core repo, but only to the gerrit review repo. In order to merge the patch into our core repo(typically master) a committer, needs to hit merge in gerrit, then will mark the patch as merged in gerrit, and commit it to the master repo.
>
> the committer that does the merge becomes the committer in git, the author in our core repo becomes:
 >
> 1) gerrit author, if gerrit committer == committer who does the merge

Sorry, what is the “gerrit author”? Do you mean the owner?

> 2) else gerrit committer.

Do you have an example commit, where that happened? I think, then I 
would understand it better.

I still don’t understand, why the author metadata should be changed in 
the first place.


Kind regards,

Paul


More information about the LibreOffice mailing list