Gerrit: mark patches as waiting for review

Bjoern Michaelsen bjoern.michaelsen at canonical.com
Tue Jan 3 12:16:21 UTC 2017


Hi,

On Tue, Jan 03, 2017 at 01:05:59PM +0100, Michael Stahl wrote:
> that is a valid use case for submitting something with a -1 self-review.

Whops, yes. I overlooked that you changed to explicitly marking incomplete
changes to CR-1 (instead of having them at CR0). So sorry about the ranting --
yes, having WIP changes should be ok as long as they come with a self-inflicted
-1 (or -2).

As long as Code-Review=0 only contains stuff that really needs a review, its
fine.

Sorry about the noise.

Best,

Bjoern


More information about the LibreOffice mailing list