[Firebird-devel] MacOS build fail "SSE4.2 instruction set not enabled"

[Julien]

I gave a try but had this:
lo/lode/dev/core/workdir/UnpackedTarball/firebird/src/common/CRC32C.cpp:41:10: error: always_inline function '_mm_crc32_u8' requires target feature 'sse4.1', but would be inlined into function 'CRC32C' that is compiled without support for 'sse4.1'
                return _mm_crc32_u8(hash_value, *value);
                       ^
Are you sure msse4 shouldn't be added in CXXFLAGS instead of COMMON_FLAGS?

Here's the content of the file prefix.darwin_x86_64 :
#DYLD_PRINT_ENV=1
#export DYLD_PRINT_ENV

#DYLD_PRINT_LIBRARIES=1
#export DYLD_PRINT_LIBRARIES

MACOSX_DEPLOYMENT_TARGET=10.7
export MACOSX_DEPLOYMENT_TARGET

PROD_FLAGS=-O1 -DDARWIN -pipe -MMD -fPIC -fno-common
DEV_FLAGS=-ggdb -DDARWIN -pipe -MMD -fPIC -fno-omit-frame-pointer -fno-common -Wall -fno-optimize-sibling-calls -Wno-non-virtual-dtor
CXXFLAGS:=$(CXXFLAGS) -fvisibility-inlines-hidden -fvisibility=hidden

EXE_LINK_OPTIONS:=
UNDEF_PLATFORM=

LINK_LIBS+=-liconv
MATHLIB=-ltommath
SO_LINK_LIBS+=-liconv

include $(ROOT)/gen/darwin.defaults

# This file must be compiled with SSE4.2 support
%/CRC32C.o: COMMON_FLAGS += -msse4

Julien

--------------------------------------------
En date de : Ven 12.5.17, Alex Peshkoff <peshkoff at mail.ru> a écrit :

 Objet: Re: [Firebird-devel] MacOS build fail "SSE4.2 instruction set not enabled"
 À: "For discussion among Firebird Developers" <firebird-devel at lists.sourceforge.net>, "Tomaž Vajngerl" <quikee at gmail.com>
 Cc: "libreoffice-dev" <libreoffice at lists.freedesktop.org>, "julien2412" <serval2412 at yahoo.fr>
 Date: Vendredi 12 mai 2017, 12h08
 
 On 05/12/17 12:05, marius adrian
 popa wrote:
 > Known issue in Firebird 3.0.x
 >
 > http://firebird.1100200.n4.nabble.com/std-c-11-added-to-CXXFLAGS-in-3-0-on-linux-td4645224.html
 >
 > introduced by this
 commit
 >
 > https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d
 
 I can't check myself mac
 issues, but sooner of all attached patch should 
 help.