MacOS build fail "SSE4.2 instruction set not enabled" (abandonned)

[Julien Nabet]

Hi,

As I put on the gerrit patch, I give up with this patch because:
- it's too complicated to modify the patch : the patching part was 
working on my Mac and it fails to apply on Jenkins Mac
- sse4 pb. Even if it builds, LO may crash on pc which aren't compatible 
with sse4

Julien

On 12/05/2017 14:33, marius adrian popa wrote:
> Also in firebird/extern/cloop/src/tests/test1/CTest.c
>
> related to this patch
> https://gerrit.libreoffice.org/#/c/37488/6/external/firebird/firebird-macosx.patch.1
>
> these lines and changes are still needed for osx
>  #include "CalcCApi.h"
> -#include <malloc.h>
> +#include <stdlib.h>
>  #include <stdio.h>
>
> now build fails 
> https://ci.libreoffice.org/job/lo_gerrit/11317/Config=macosx_clang_dbgutil/
>
> On Fri, May 12, 2017 at 1:10 PM, Tomaž Vajngerl <quikee at gmail.com 
> <mailto:quikee at gmail.com>> wrote:
>
>     Hi,
>
>     On Fri, May 12, 2017 at 11:05 AM, marius adrian popa
>     <mapopa at gmail.com <mailto:mapopa at gmail.com>> wrote:
>     > Known issue in Firebird 3.0.x
>     >
>     >
>     http://firebird.1100200.n4.nabble.com/std-c-11-added-to-CXXFLAGS-in-3-0-on-linux-td4645224.html
>     <http://firebird.1100200.n4.nabble.com/std-c-11-added-to-CXXFLAGS-in-3-0-on-linux-td4645224.html>
>     >
>     > introduced by this commit
>     >
>     > https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d
>     <https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d>
>     >
>
>     They would need to add something like "%/CRC32C.o: COMMON_FLAGS +=
>     -msse4" to prefix.darwin too (clang should have compatible switches)
>
>     For Windows It is complicated as it depends if the particular VS
>     version supports the instructions or not, but you need to add some
>     compile switch too...
>
>     That's only for compiler - in addition you also need run-time
>     detection, but I see this is already covered by SSE4_2Supported()
>     method.
>
>     Regards, Tomaž
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20170513/78497a03/attachment.html>