Gerrit review blocked on "Needs Code-Style"
sbergman at redhat.com
Wed Nov 8 07:09:29 UTC 2017
On 11/07/2017 11:43 PM, Thorsten Behrens wrote:
> Stephan Bergmann wrote:
>> Why is <https://gerrit.libreoffice.org/#/c/44418/> "Suppress
>> loplugin:unnecessaryoverride..." blocked on "Needs Code-Style" (and which I
>> at least cannot override via some +1 reply)?
> See mail a moment ago. Missed the fact that the gerrit default submit
> rule is in effect 'all labels need to be present, and at max
> value'. Hopefully now fixed with a (temporary) submit filter rule (in
> prolog, ugh)...
Yes, thanks, the Code-Style flag and accompanying "Needs Code-Style"
mode are completely gone again from that Gerrit change.
More information about the LibreOffice