[Libreoffice-commits] core.git: include/svl sc/qa sc/sdi sc/source sc/uiconfig sfx2/source

[Henry Castro]

Hi Eike,

> What is this supposed to do? It adds a non-functional status bar item to
> Calc that only takes precious space to display the global document
> language and all associated context menu entries to change language are
> without functionality.

The idea was to show only the language status, not the context menu, perhaps
I forgot some flags to disable them, but I added to my queue task
list, to fix those
unwanted context menu on language status bar.

> Spell checking in Calc does not work this way with a global document
> language or paragraph language, language is a cell attribute (or in-cell
> EditEngine text portion attribute).

Indeed, after reading code they are designed to cell attribute, but I did not
find anything to apply this, since they are not set, the cell take the global
document language

Regards
Henry



2017-11-14 16:19 GMT-04:00 Eike Rathke <erack at redhat.com>:
> Hi Henry,
>
> On Sunday, 2017-10-22 15:18:38 +0000, Henry Castro wrote:
>
>>  include/svl/hint.hxx                         |    1
>>  sc/qa/unit/tiledrendering/tiledrendering.cxx |   51 +++++++++++++++
>>  sc/sdi/docsh.sdi                             |    1
>>  sc/source/ui/docshell/docsh4.cxx             |   89 +++++++++++++++++++++++++++
>>  sc/source/ui/view/gridwin4.cxx               |    1
>>  sc/source/ui/view/tabvwsh5.cxx               |    8 ++
>>  sc/uiconfig/scalc/menubar/menubar.xml        |    2
>>  sc/uiconfig/scalc/statusbar/statusbar.xml    |    1
>>  sfx2/source/control/unoctitm.cxx             |   13 +++
>>  9 files changed, 165 insertions(+), 2 deletions(-)
>>
>> New commits:
>> commit 2fa424f40a185eb43d862a29abce07345695fcf3
>> Author: Henry Castro <hcastro at collabora.com>
>> Date:   Thu Oct 19 22:47:17 2017 -0400
>>
>>     sc lok: fix spell checking languages in Calc
>
> What is this supposed to do? It adds a non-functional status bar item to
> Calc that only takes precious space to display the global document
> language and all associated context menu entries to change language are
> without functionality.
>
> Spell checking in Calc does not work this way with a global document
> language or paragraph language, language is a cell attribute (or in-cell
> EditEngine text portion attribute).
>
>   Eike
>
> --
> LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
> GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
> Care about Free Software, support the FSFE https://fsfe.org/support/?erack
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>