Let failed Jenkins builds set Verified: -1 in Gerrit?

Miklos Vajna vmiklos at collabora.co.uk
Thu Nov 30 08:00:16 UTC 2017


Hi Stephan,

On Wed, Nov 29, 2017 at 12:16:24PM +0100, Stephan Bergmann <sbergman at redhat.com> wrote:
> Is there any good reason why a failed Gerrit/Jenkins build does not set the
> corresponding Gerrit change's Verified flag to -1 (similar to how a
> successful such build sets the flag to +1)?
> 
> Especially with the poor Jenkins turnaround times, it is hard to tell on a
> page like <https://gerrit.libreoffice.org/#/dashboard/self> whether a change
> is not yet ready for submission because Jenkins has not yet built it or
> because the Jenkins build failed.  The "V" ("Verified") column is empty in
> both cases.  (And I assume it would contain something like a red cross if
> the Verified flag is -1.)

I think this was a decision from Norbert, probably because he was worried
about false negatives. A workaround is to watch your inbox (which gets a
mail, whatever is the outcome), rather than the above URL.

(I would have no problem if Jenkins would put a Verified-1, though.)

Regards,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20171130/a1e492a9/attachment.sig>


More information about the LibreOffice mailing list