New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1419948:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/sal/osl/unx/file.cxx: 1151 in <unnamed>::exceedsOffT<long>(T1)()


________________________________________________________________________________________________________
*** CID 1419948:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/sal/osl/unx/file.cxx: 1151 in <unnamed>::exceedsOffT<long>(T1)()
1145     }
1146     
1147     const off_t MAX_OFF_T = std::numeric_limits< off_t >::max();
1148     
1149     namespace {
1150     
>>>     CID 1419948:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "n > 9223372036854775807L /* MAX_OFF_T */" is always false regardless of the values of its operands. This occurs as a return value.
1151     template<typename T> bool exceedsOffT(T n) { return n > MAX_OFF_T; }
1152     
1153     }
1154     
1155     oslFileError SAL_CALL osl_mapFile(
1156         oslFileHandle Handle,

** CID 705523:    (NULL_RETURNS)
/sw/source/uibase/utlui/content.cxx: 2071 in SwContentTree::HasContentChanged()()
/sw/source/uibase/utlui/content.cxx: 2141 in SwContentTree::HasContentChanged()()
/sw/source/uibase/utlui/content.cxx: 2180 in SwContentTree::HasContentChanged()()
/sw/source/uibase/utlui/content.cxx: 2191 in SwContentTree::HasContentChanged()()


________________________________________________________________________________________________________
*** CID 705523:    (NULL_RETURNS)
/sw/source/uibase/utlui/content.cxx: 2071 in SwContentTree::HasContentChanged()()
2065                                 bRepaint = true;
2066                         else
2067                         {
2068                             const size_t nChildCount = GetChildCount(pEntry);
2069                             for(size_t j = 0; j < nChildCount; ++j)
2070                             {
>>>     CID 705523:    (NULL_RETURNS)
>>>     Assigning: "pEntry" = null return value from "Next".
2071                                 pEntry = Next(pEntry);
2072                                 const SwContent* pCnt = pArrType->GetMember(j);
2073                                 pEntry->SetUserData(const_cast<SwContent *>(pCnt));
2074                                 OUString sEntryText = GetEntryText(pEntry);
2075                                 if( sEntryText != pCnt->GetName() &&
2076                                     !(sEntryText == m_sSpace && pCnt->GetName().isEmpty()))
/sw/source/uibase/utlui/content.cxx: 2141 in SwContentTree::HasContentChanged()()
2135                         if(nChildCount != pArrType->GetMemberCount())
2136                             bRepaint = true;
2137                         else
2138                         {
2139                             for(size_t j = 0; j < nChildCount; ++j)
2140                             {
>>>     CID 705523:    (NULL_RETURNS)
>>>     Assigning: "pEntry" = null return value from "Next".
2141                                 pEntry = Next(pEntry);
2142                                 bNext = false;
2143                                 const SwContent* pCnt = pArrType->GetMember(j);
2144                                 pEntry->SetUserData(const_cast<SwContent *>(pCnt));
2145                                 OUString sEntryText = GetEntryText(pEntry);
2146                                 if( sEntryText != pCnt->GetName() &&
/sw/source/uibase/utlui/content.cxx: 2180 in SwContentTree::HasContentChanged()()
2174                                 const SwContent* pCnt = pArrType->GetMember(j);
2175                                 pChild->SetUserData(const_cast<SwContent *>(pCnt));
2176                                 OUString sEntryText = GetEntryText(pChild);
2177                                 if( sEntryText != pCnt->GetName() &&
2178                                     !(sEntryText == m_sSpace && pCnt->GetName().isEmpty()))
2179                                     bRemoveChildren = true;
>>>     CID 705523:    (NULL_RETURNS)
>>>     Assigning: "pChild" = null return value from "Next".
2180                                 pChild = Next(pChild);
2181                             }
2182                         }
2183                         if(bRemoveChildren)
2184                         {
2185                             SvTreeListEntry* pChild = FirstChild(pEntry);
/sw/source/uibase/utlui/content.cxx: 2191 in SwContentTree::HasContentChanged()()
2185                             SvTreeListEntry* pChild = FirstChild(pEntry);
2186                             SvTreeListEntry* pRemove = pChild;
2187                             for(size_t j = 0; j < nChildCount; ++j)
2188                             {
2189                                 pChild = Next(pRemove);
2190                                 GetModel()->Remove(pRemove);
>>>     CID 705523:    (NULL_RETURNS)
>>>     Assigning: "pRemove" = "pChild".  Both pointers are now null.
2191                                 pRemove = pChild;
2192                             }
2193                         }
2194                         if(!nChildCount)
2195                         {
2196                             pEntry->EnableChildrenOnDemand(false);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy330RVpcc3bI2d-2B59TSnNIN-2FsWRPXf5a8qAsgK2CQWzeaLB52micXGBYhDfTinAxHyAnBDYb-2FweAroguQwS504qJE6b-2FNL0tvoeZvYsWZtJK-2BUqC5CSmIKmj67HZlG4Q2SY4dNgUvTEcsboGCZSnVckw7-2BAl2vyBht4zXsM8d4W4-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy330RVpcc3bI2d-2B59TSnNIH0y9GlbyIvlC3eySlVqQ-2Fk-2F1rCkaIJCB2oIG1jex0Qz9MPOegEjbKQ-2FU1G6TwIh7JIdU14fA2nB9qgbfK1VVQS7O221i2SAarwYduYzrgWp4g4XUqBw2fRivp4urmQ0QDSb-2Fub8hlpPFzPTy2UHfmg-3D