New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1420317:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/view/drviews2.cxx: 330 in sd::ClassificationCollector::collect()()


________________________________________________________________________________________________________
*** CID 1420317:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/view/drviews2.cxx: 330 in sd::ClassificationCollector::collect()()
324                                 m_pRectObject = pRectObject;
325                                 for (editeng::Section const & rSection : aSections)
326                                 {
327                                     const SvxFieldItem* pFieldItem = findField(rSection);
328                                     if (pFieldItem)
329                                     {
>>>     CID 1420317:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "pCustomPropertyField" = "dynamic_cast <editeng::CustomPropertyField const *>(pFieldItem->GetField())".
330                                         const auto* pCustomPropertyField = dynamic_cast<const editeng::CustomPropertyField*>(pFieldItem->GetField());
331                                         OUString aKey = pCustomPropertyField->GetKey();
332                                         if (aKey.startsWith(sPolicy + "Marking:Text:"))
333                                         {
334                                             OUString aValue = lcl_getProperty(xPropertyContainer, aKey);
335                                             m_aResults.push_back({ svx::ClassificationType::TEXT, aValue, nParagraph });

** CID 1420316:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/sal/osl/unx/file.cxx: 1155 in <unnamed>::exceedsMinOffT<long>(T1)()


________________________________________________________________________________________________________
*** CID 1420316:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/sal/osl/unx/file.cxx: 1155 in <unnamed>::exceedsMinOffT<long>(T1)()
1149     namespace {
1150     
1151     //coverity[result_independent_of_operands]
1152     template<typename T> bool exceedsMaxOffT(T n) { return n > MAX_OFF_T; }
1153     
1154     template<typename T> bool exceedsMinOffT(T n)
>>>     CID 1420316:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "n < -9223372036854775808L" is always false regardless of the values of its operands. This occurs as a return value.
1155     { return n < std::numeric_limits<off_t>::min(); }
1156     
1157     }
1158     
1159     oslFileError SAL_CALL osl_mapFile(
1160         oslFileHandle Handle,

** CID 1420315:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/draw/dflyobj.cxx: 403 in SwVirtFlyDrawObj::Rotate(const Point &, long, double, double)()


________________________________________________________________________________________________________
*** CID 1420315:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/draw/dflyobj.cxx: 403 in SwVirtFlyDrawObj::Rotate(const Point &, long, double, double)()
397     
398             if(0 != nAngle)
399             {
400                 // RotGrfFlyFrame: Add transformation to placeholder object
401                 Size aSize;
402                 const sal_uInt16 nOldRot(SwVirtFlyDrawObj::getPossibleRotationFromFraphicFrame(aSize));
>>>     CID 1420315:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "pSh" = "dynamic_cast <SwWrtShell *>(this->GetFlyFrame()->getRootFrame()->GetCurrShell())".
403                 SwWrtShell *pSh = dynamic_cast<SwWrtShell*>( GetFlyFrame()->getRootFrame()->GetCurrShell() );
404                 SwFlyFrameAttrMgr aMgr(false, pSh, Frmmgr_Type::NONE);
405     
406                 aMgr.SetRotation(nOldRot, (nOldRot + static_cast<sal_uInt16>(nAngle)) % 3600, aSize);
407             }
408         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyj3JREHMjT-2FcUjmeJVZmXXu3BZlD6CRytoojjZYLmROzpvaZQMQXpwXrUpC67CWoCi-2FnTZ6wCHOPgcXHYTa6hykQmJF5NxDBz-2BwD79sbKBsovpNyn2jDEuuLNSna5GUYxrQwkVcg-2BVWLkv2cKqI7nuGJJ4yQv1K2pOl2cpPkx9to-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyj3JREHMjT-2FcUjmeJVZmXXn39WRU5Dh-2BTGXGy31dPQVFJTQ37YepcH18y3HFRqovgf45Ay-2FW472Xf5A5TPo3m5IZ6ILZFaqXh00m-2BOqJ7KevIQrDX0SCvruVARgxK8P2ZkXBszXVdUbpbyJQif71-2FIOEYK5T9NjKJURStgqb0Wd4-3D