core.git: desktop/source include/LibreOfficeKit

Jan Holesovsky kendy at collabora.com
Thu Sep 14 08:48:09 UTC 2017


Hi Michael,

Michael Stahl píše v Čt 14. 09. 2017 v 10:06 +0200:

> > -static void lo_setOptionalFeatures(LibreOfficeKit* pThis, uint64_t
> > features);
> > +static
> > void                    lo_setOptionalFeatures(LibreOfficeKit*
> > pThis, unsigned long long features);
> 
> uhm, did you know "long long" is not C89 or C++98 either?
> 
> https://gcc.gnu.org/onlinedocs/gcc/Long-Long.html

First of all I wanted to do that only 'unsigned long', but then noticed
the LibreOfficeKitOptionalFeatures constants were defined as '1ULL <<
...', so rather used unsigned long long.

So - should I change that to 'unsigned long'?

> this is quite depressing anyway, not only is our entire industry
> based
> on a relic from the 1970s, in practice we can't even use the 1990s
> update of the relic that is old enough to vote...

:-)

All the best,
Kendy


More information about the LibreOffice mailing list