core.git: desktop/source include/LibreOfficeKit

Michael Stahl mstahl at redhat.com
Thu Sep 14 08:06:14 UTC 2017


On 14.09.2017 09:51, Jan Holesovsky wrote:
> New commits:
> commit 5bcc79e825d542c40c9ee0f48d1d72ea9aa53c54
> Author: Jan Holesovsky <kendy at collabora.com>
> Date:   Thu Sep 14 09:23:46 2017 +0200
> 
>     [API CHANGE] lok: Don't use 'bool' and 'uint64_t' in the stable API.

> diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
> index ad88ab270252..6e8136d740a0 100644
> --- a/desktop/source/lib/init.cxx
> +++ b/desktop/source/lib/init.cxx
> @@ -1098,12 +1098,12 @@ static void                    lo_registerCallback (LibreOfficeKit* pThis,
>                                                      LibreOfficeKitCallback pCallback,
>                                                      void* pData);
>  static char* lo_getFilterTypes(LibreOfficeKit* pThis);
> -static void lo_setOptionalFeatures(LibreOfficeKit* pThis, uint64_t features);
> +static void                    lo_setOptionalFeatures(LibreOfficeKit* pThis, unsigned long long features);

uhm, did you know "long long" is not C89 or C++98 either?

https://gcc.gnu.org/onlinedocs/gcc/Long-Long.html

this is quite depressing anyway, not only is our entire industry based
on a relic from the 1970s, in practice we can't even use the 1990s
update of the relic that is old enough to vote...



More information about the LibreOffice mailing list