New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1438474:  Control flow issues  (DEADCODE)
/include/rtl/stringutils.hxx: 176 in rtl::libreoffice_internal::ConstCharArrayDetector<const char [1], void>::isValid(const char (&)[1])()


________________________________________________________________________________________________________
*** CID 1438474:  Control flow issues  (DEADCODE)
/include/rtl/stringutils.hxx: 176 in rtl::libreoffice_internal::ConstCharArrayDetector<const char [1], void>::isValid(const char (&)[1])()
170         static const bool ok = true;
171     #if defined LIBO_INTERNAL_ONLY && HAVE_CXX14_CONSTEXPR
172         constexpr
173     #endif
174         static bool isValid(char const (& literal)[N]) {
175             for (std::size_t i = 0; i != N - 1; ++i) {
>>>     CID 1438474:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "if ((*literal)[i] == 0) {
 ...".
176                 if (literal[i] == '\0') {
177                     return false;
178                 }
179             }
180             return literal[N - 1] == '\0';
181         }

** CID 1438473:  Control flow issues  (DEADCODE)
/include/rtl/stringutils.hxx: 176 in rtlunittest::libreoffice_internal::ConstCharArrayDetector<const char [1], void>::isValid(const char (&)[1])()


________________________________________________________________________________________________________
*** CID 1438473:  Control flow issues  (DEADCODE)
/include/rtl/stringutils.hxx: 176 in rtlunittest::libreoffice_internal::ConstCharArrayDetector<const char [1], void>::isValid(const char (&)[1])()
170         static const bool ok = true;
171     #if defined LIBO_INTERNAL_ONLY && HAVE_CXX14_CONSTEXPR
172         constexpr
173     #endif
174         static bool isValid(char const (& literal)[N]) {
175             for (std::size_t i = 0; i != N - 1; ++i) {
>>>     CID 1438473:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "if ((*literal)[i] == 0) {
 ...".
176                 if (literal[i] == '\0') {
177                     return false;
178                 }
179             }
180             return literal[N - 1] == '\0';
181         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyfh-2F2idhMgHMzCx4zBou-2BYC70xHMvajYyEcni2R2zaKIdPDNPI3b3nJ9NRLXEOU1nuDpEuximakh9R1jq9eVpTnsTccqY1uhB2BMZK5JuRW6rrxPiMwdaDz6PqAOAyy8q2TEMYSvaviRD3BL3ZMlqizvaM0mxQpA181RbwtsI0F4-3D