New Defects reported by Coverity Scan for LibreOffice

[Stephan Bergmann]

On 22/08/18 12:31, scan-admin at coverity.com wrote:
> ** CID 1438474:  Control flow issues  (DEADCODE)
> /include/rtl/stringutils.hxx: 176 in rtl::libreoffice_internal::ConstCharArrayDetector<const char [1], void>::isValid(const char (&)[1])()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 1438474:  Control flow issues  (DEADCODE)
> /include/rtl/stringutils.hxx: 176 in rtl::libreoffice_internal::ConstCharArrayDetector<const char [1], void>::isValid(const char (&)[1])()
> 170         static const bool ok = true;
> 171     #if defined LIBO_INTERNAL_ONLY && HAVE_CXX14_CONSTEXPR
> 172         constexpr
> 173     #endif
> 174         static bool isValid(char const (& literal)[N]) {
> 175             for (std::size_t i = 0; i != N - 1; ++i) {
>>>>      CID 1438474:  Control flow issues  (DEADCODE)
>>>>      Execution cannot reach this statement: "if ((*literal)[i] == 0) {
>   ...".

who's being dumb here, me or Coverity?

> 176                 if (literal[i] == '\0') {
> 177                     return false;
> 178                 }
> 179             }
> 180             return literal[N - 1] == '\0';
> 181         }