[Libreoffice-commits] core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild

[Rene Engelhard]

Hi,

On Tue, Feb 20, 2018 at 09:22:10PM +0000, Samuel Thibault wrote:
> New commits:
> commit 226697ae27ef451cad404256e83eef88262f16d1
> Author: Samuel Thibault <sthibault at hypra.fr>
> Date:   Fri Feb 16 13:22:10 2018 +0100
> 
>     Integrate initial version of gla11y tool in the build system
>     
>     This is part of integrating an accessibility non-regression tool. This
>     adds checks in configure.ac for the presence of python lxml which we will
>     need, and adds support for calling the tool at build time, to check for
>     definite UI errors. For now, that only emits errors for missing or duplicate
>     accessibility relation targets, and senseless relations: a label being
>     mnemonic for several widgets.
>     
>     Change-Id: Idda91b15b9a9e0322d16db33dfac8e03f2aa518c
>     Reviewed-on: https://gerrit.libreoffice.org/49856
>     Tested-by: Jenkins <ci at libreoffice.org>
>     Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

Was this ever really tested besides Jenkins (no idea with what build
config this was tested...)?

> diff --git a/bin/gla11y b/bin/gla11y
> new file mode 100755
> index 000000000000..d0619133ad0f
> --- /dev/null
> +++ b/bin/gla11y
> @@ -0,0 +1,216 @@
> +#!/usr/bin/env python

That's "python". Python2.

[...]

> diff --git a/configure.ac b/configure.ac
> index e20e91e7fa42..479968be94b9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -8148,10 +8148,19 @@ if test $enable_python = system; then
>  fi
>  
>  dnl By now enable_python should be "system", "internal" or "no"
> +PYTHON_LXML=
>  case $enable_python in
>  system)
>      SYSTEM_PYTHON=TRUE
>  
> +    AC_MSG_CHECKING([for python lxml])
> +    if $PYTHON -c "import lxml.etree as ET" ; then
> +        PYTHON_LXML=TRUE
> +        AC_MSG_RESULT([yes])
> +    else
> +        AC_MSG_RESULT([no, will not be able to check UI accessibility])
> +    fi
> +
>      dnl Check if the headers really work
>      save_CPPFLAGS="$CPPFLAGS"
>      CPPFLAGS="$CPPFLAGS $PYTHON_CFLAGS"


Here it checks for lxml in the system python. This is a a 3.x.
Because for python3-uno in Debian, of course python3 is used.
And LOs internal python also is python3. 

But the actual script (see above) calls "python" and not "python3"

Even if installing python-xml (for the actual script) and python3
(for the configure check) it complains about no input files or somesuch
and fails....

Regards,

Rene