[Libreoffice-commits] core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild

[Samuel Thibault]

Hello,

Rene Engelhard, on mer. 21 févr. 2018 09:11:02 +0100, wrote:
> Was this ever really tested besides Jenkins (no idea with what build
> config this was tested...)?

I did test it, but apparently not in all potential situations.

> > diff --git a/bin/gla11y b/bin/gla11y
> > new file mode 100755
> > index 000000000000..d0619133ad0f
> > --- /dev/null
> > +++ b/bin/gla11y
> > @@ -0,0 +1,216 @@
> > +#!/usr/bin/env python
> 
> That's "python". Python2.

It works with either python2 or python3

> > +    AC_MSG_CHECKING([for python lxml])
> > +    if $PYTHON -c "import lxml.etree as ET" ; then
> 
> Here it checks for lxml in the system python. This is a a 3.x.
> Because for python3-uno in Debian, of course python3 is used.
> And LOs internal python also is python3. 
> 
> But the actual script (see above) calls "python" and not "python3"

Mmm, so we should make it a .py.in file to be able to put @PYTHON@ in the script?

> Even if installing python-xml (for the actual script) and python3
> (for the configure check) it complains about no input files or somesuch
> and fails....

Indeed, I sent a fix for that

https://gerrit.libreoffice.org/50071

Samuel