[Libreoffice-commits] core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild

Stephan Bergmann sbergman at redhat.com
Wed Feb 21 08:26:03 UTC 2018


On 21.02.2018 09:19, Samuel Thibault wrote:
> Rene Engelhard, on mer. 21 févr. 2018 09:11:02 +0100, wrote:
>>> diff --git a/bin/gla11y b/bin/gla11y
>>> new file mode 100755
>>> index 000000000000..d0619133ad0f
>>> --- /dev/null
>>> +++ b/bin/gla11y
>>> @@ -0,0 +1,216 @@
>>> +#!/usr/bin/env python
>>
>> That's "python". Python2.
> 
> It works with either python2 or python3
> 
>>> +    AC_MSG_CHECKING([for python lxml])
>>> +    if $PYTHON -c "import lxml.etree as ET" ; then
>>
>> Here it checks for lxml in the system python. This is a a 3.x.
>> Because for python3-uno in Debian, of course python3 is used.
>> And LOs internal python also is python3.
>>
>> But the actual script (see above) calls "python" and not "python3"
> 
> Mmm, so we should make it a .py.in file to be able to put @PYTHON@ in the script?

Drop the shebang line and call it as `$(PYTHON) $(SRCDIR)/bin/gla11y` 
from the makefile?


More information about the LibreOffice mailing list