CppunitTest_sc_tabviewobj failing on Windows MSVC 2017

[Luke Benes]

 Jens Carl,
When I went to test this on a different windows machine that has OpenCL enabled, the same commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=600987b4

tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++

caused the following build failure:

[build CUT] sc_opencl_test
ScOpenCLTest::testLogicalFormulaXor finished in: 2198ms
D:/core/sc/qa/unit/opencl-test.cxx:4143:ScOpenCLTest::testDatabaseFormulaDmax
double equality assertion failed
- Expected: 46
- Actual  : 0
- Delta   : 1e-11

ScOpenCLTest::testDatabaseFormulaDmax finished in: 252ms
...
ScOpenCLTest::testStatisticalFormulaStDevPA1 finished in: 152ms
ScOpenCLTest::testFinancialMDurationFormula1 finished in: 294ms
D:/core/sc/qa/unit/opencl-test.cxx(4143) : error : Assertion
Test name: ScOpenCLTest::testDatabaseFormulaDmax
double equality assertion failed
- Expected: 46
- Actual  : 0
- Delta   : 1e-11

Failures !!!
Run: 223   Failure total: 1   Failures: 1   Errors: 0

Error: a unit test failed, please do one of:
make CppunitTest_sc_opencl_test CPPUNITTRACE=TRUE # which is a shortcut for the following line
make CppunitTest_sc_opencl_test CPPUNITTRACE="'C:/Program Files (x86)/Microsoft Visual Studio 14.0/Common7/IDE/devenv.exe' /debugexe" # for interactive debugging in Visual Studio
make CppunitTest_sc_opencl_test CPPUNITTRACE="drmemory -free_max_frames 20" # for memory checking (install Dr.Memory first, and put it to your PATH)

You can limit the execution to just one particular test by:

make CppunitTest_sc_opencl_test CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...

make[1]: *** [D:/core/solenv/gbuild/CppunitTest.mk:115: D:/core/workdir/CppunitTest/sc_opencl_test.test] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:286: build] Error 2


So in summary:

Old sandybridge with OpenCL blacklisted + MSVC 2017:
CppunitTest_sc_tabviewobj FAIL

Broadwell with OpenCL whitelisted:
CppunitTest_sc_opencl_test FAIL

Reverting this commit allows a `make check` to succeed on both systems.

-Luke
________________________________
From: Luke Benes <lukebenes at hotmail.com>
Sent: Saturday, June 16, 2018 8:08 PM
To: Libreoffice Dev List; j.carl43 at gmx.de
Subject: CppunitTest_sc_tabviewobj failing on Windows MSVC 2017


Ever since https://cgit.freedesktop.org/libreoffice/core/commit/?id=600987b4

tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++

Windows builds are failing with the following error:

[build CUT] sc_arealinkobj
sc_apitest::ScTabViewObj::testSpreadsheetViewSettingsProperties finished in: 2516ms
sc_apitest::ScTabViewObj::testAddRemoveActivationEventListener finished in: 603ms
C:/core/test/source/sheet/xcellrangereferrer.cxx:32:sc_apitest::ScTabViewObj::testGetReferredCells
equality assertion failed
- Expected: Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 13
- Actual  : Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 23

sc_apitest::ScTabViewObj::testGetReferredCells finished in: 634ms
sc_apitest::ScTabViewObj::testGetSetActiveSheet finished in: 572ms
sc_apitest::ScTabViewObj::testFreeze finished in: 660ms
sc_apitest::ScTabViewObj::testSplit finished in: 679ms
C:/core/test/source/sheet/xcellrangereferrer.cxx(32) : error : Assertion
Test name: sc_apitest::ScTabViewObj::testGetReferredCells
equality assertion failed
- Expected: Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 13
- Actual  : Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 23

Failures !!!
Run: 6   Failure total: 1   Failures: 1   Errors: 0

Error: a unit test failed, please do one of:
make CppunitTest_sc_tabviewobj CPPUNITTRACE=TRUE # which is a shortcut for the following line
make CppunitTest_sc_tabviewobj CPPUNITTRACE="'C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/Common7/IDE/devenv.exe' /debugexe" # for interactive debugging in Visual Studio
make CppunitTest_sc_tabviewobj CPPUNITTRACE="drmemory -free_max_frames 20" # for memory checking (install Dr.Memory first, and put it to your PATH)

You can limit the execution to just one particular test by:

make CppunitTest_sc_tabviewobj CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...

make[1]:
make[1]:
Makefile:286: recipe for target 'build' failed

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20180618/b23aa9b4/attachment.html>