New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
32 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1430232:  Null pointer dereferences  (REVERSE_INULL)
/cui/source/tabpages/transfrm.cxx: 668 in SvxSlantTabPage::Reset(const SfxItemSet *)()


________________________________________________________________________________________________________
*** CID 1430232:  Null pointer dereferences  (REVERSE_INULL)
/cui/source/tabpages/transfrm.cxx: 668 in SvxSlantTabPage::Reset(const SfxItemSet *)()
662         m_pMtrAngle->SaveValue();
663     
664         bool bSelectionIsSdrObjCustomShape(false);
665     
666         while(true)
667         {
>>>     CID 1430232:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "this->pView" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
668             if(nullptr == pView)
669             {
670                 break;
671             }
672     
673             if(1 != pView->GetMarkedObjectList().GetMarkCount())

** CID 1430231:  Error handling issues  (CHECKED_RETURN)
/filter/source/pdf/pdfinteract.cxx: 65 in PDFInteractionHandler::handleInteractionRequest(const com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> &)()


________________________________________________________________________________________________________
*** CID 1430231:  Error handling issues  (CHECKED_RETURN)
/filter/source/pdf/pdfinteract.cxx: 65 in PDFInteractionHandler::handleInteractionRequest(const com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> &)()
59             sal_Int32 nCodes = aExc.ErrorCodes.getLength();
60             for( sal_Int32 i = 0; i < nCodes; i++ )
61                 aCodes.insert( static_cast<vcl::PDFWriter::ErrorCode>(aExc.ErrorCodes.getConstArray()[i]) );
62     
63             VclPtr<vcl::Window> xParent(VCLUnoHelper::GetWindow(m_xParent));
64             ImplErrorDialog aDlg(xParent ? xParent->GetFrameWeld() : nullptr, aCodes);
>>>     CID 1430231:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "run" without checking return value (as is done elsewhere 52 out of 65 times).
65             aDlg.run();
66             bHandled = true;
67         }
68         return bHandled;
69     }
70     

** CID 1430230:  Error handling issues  (CHECKED_RETURN)
/cui/source/customize/cfg.cxx: 3319 in SvxIconSelectorDialog::ImportGraphics(const com::sun::star::uno::Sequence<rtl::OUString> &)()


________________________________________________________________________________________________________
*** CID 1430230:  Error handling issues  (CHECKED_RETURN)
/cui/source/customize/cfg.cxx: 3319 in SvxIconSelectorDialog::ImportGraphics(const com::sun::star::uno::Sequence<rtl::OUString> &)()
3313             for ( sal_Int32 i = 0; i < rejectedCount; ++i )
3314             {
3315                 message += fPath + rejected[i] + "\n";
3316             }
3317     
3318             SvxIconChangeDialog aDialog(GetFrameWeld(), message);
>>>     CID 1430230:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "run" without checking return value (as is done elsewhere 52 out of 65 times).
3319             aDialog.run();
3320         }
3321     }
3322     
3323     bool SvxIconSelectorDialog::ImportGraphic( const OUString& aURL )
3324     {

** CID 1430229:  Error handling issues  (CHECKED_RETURN)
/sw/source/ui/dbui/mmoutputtypepage.cxx: 551 in SwSendMailDialog::DocumentSent(const com::sun::star::uno::Reference<com::sun::star::mail::XMailMessage> &, bool, const rtl::OUString *)()


________________________________________________________________________________________________________
*** CID 1430229:  Error handling issues  (CHECKED_RETURN)
/sw/source/ui/dbui/mmoutputtypepage.cxx: 551 in SwSendMailDialog::DocumentSent(const com::sun::star::uno::Reference<com::sun::star::mail::XMailMessage> &, bool, const rtl::OUString *)()
545     
546         UpdateTransferStatus( );
547     
548         if (pError)
549         {
550             SwSendWarningBox_Impl aDlg(GetFrameWeld(), *pError);
>>>     CID 1430229:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "run" without checking return value (as is done elsewhere 52 out of 65 times).
551             aDlg.run();
552         }
553     }
554     
555     void SwSendMailDialog::UpdateTransferStatus()
556     {

** CID 1430228:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1430228:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/doc/docftn.cxx: 192 in SwEndNoteInfo::SwClientNotify(const SwModify &, const SfxHint &)()
186         {
187             const sal_uInt16 nWhich = pLegacyHint->m_pOld ? pLegacyHint->m_pOld->Which() : pLegacyHint->m_pNew ? pLegacyHint->m_pNew->Which() : 0 ;
188             if( RES_ATTRSET_CHG == nWhich ||
189                 RES_FMT_CHG == nWhich )
190             {
191                 auto pFormat = GetCurrentCharFormat(pCharFormat != nullptr);
>>>     CID 1430228:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pFormat" to "IsFormatInDTOR", which dereferences it.
192                 if(!aDepends.IsListeningTo(pFormat) || pFormat->IsFormatInDTOR())
193                     return;
194                 SwDoc* pDoc = pFormat->GetDoc();
195                 SwFootnoteIdxs& rFootnoteIdxs = pDoc->GetFootnoteIdxs();
196                 for( size_t nPos = 0; nPos < rFootnoteIdxs.size(); ++nPos )
197                 {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpye3X4XAVrtgdyy3vv7hx2RSOnDPoL2MzhRwxUD-2B1QLvNk2W3Q7puR9RknwDYWfzouXJGb5mLINXkAbODiSCH2QipGDZLPtzuv0c-2F0aVmAqfqSpbytL-2BHYbuokRVTijAnYhHyg5E4ShFv2BWmp2VAtFko7yfPb6oWEexUv1avaF5w-3D