problems with LayerTabBar in unit tests

[Markus Mohrhard]

Hello Regina,

On Mon, Oct 8, 2018 at 7:54 PM Regina Henschel <rb.henschel at t-online.de>
wrote:

> Hi all,
>
> does no one has an idea? I have put the problem as patch to Gerrit
> https://gerrit.libreoffice.org/61545. Perhaps my problem is easier
> understandable then.
>
> Problem: If I use the "Load"-method, I get the document loaded, but only
> the center pane has the correct size. All other window sizes have
> suspicious values. Especially the LayerTabBar has width 0, and therefore
> a click on it is not possible. But that would be needed for the unit test.
>

Many of the unit tests actually don't include any parts of the UI. So, they
are usually useless for testing that anything in the UI actually works. For
some tests you can work around it by hooking into the corresponding shell
but you will need to inspect the code and the setup of the test (e.g. your
test does not link against libsdui) to check if that is possible. I think
not many people can easily help you there for impress and draw code.

Regards,
Markus

>
> How to get the correct window sizes?
>
> Kind regards
> Regina
>
>
> Regina Henschel schrieb am 04-Oct-18 um 14:42:
> > Hi all,
> >
> > I'm still working on a unit test for bug tdf#119956. My current state
> > is, that the odg test document really opens in Draw. [On master it opens
> > in Impress.] But the layer tab bar has width 0. So simulating a click on
> > the layer tab bar is not possible, which is needed in case of bug
> > tdf#119956.
> >
> > Which layers are shown in the layer tab bar is calculated in
> > DrawViewShell::ResetActualLayer() in sd/source/ui/view/drviews1.cxx and
> > the actual width is calculated in TabBar::ImplFormat() in
> > svtools/source/control/tabbar.cxx. Please correct me, if I'm wrong about
> > this.
> >
> > So my questions are:
> >
> > What makes the method SdMiscTest::Load from misc-tests.cxx in sd/qa/unit
> > different from regular opening the file from a running LibreOffice via
> > click on Open button of the start center?
> >
> > How can I open the test file in a unit test the same way as a regular
> > Open does?
> >
> > Or what do I need to add/change in the SdMiscTest::Load method to get
> > the layer tab bar in the correct width?
> >
> > Any ideas or tips?
> >
> > Kind regards
> > Regina
> > _______________________________________________
> > LibreOffice mailing list
> > LibreOffice at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20181008/4057de75/attachment.html>