Update of file oox-drawingml-cs-presets

Miklos Vajna vmiklos at collabora.com
Fri May 17 15:53:30 UTC 2019

Hi Regina,

On Fri, May 17, 2019 at 05:00:02PM +0200, Regina Henschel <rb.henschel at t-online.de> wrote:
> to fix https://bugs.documentfoundation.org/show_bug.cgi?id=125181 it is
> needed to correct the file
> oox/source/drawingml/customshapes/presetShapeDefinitions.xml.

IIRC that file is from the OOXML spec, so please double-check that you
indeed have to change it.

> Do I need to include all changed files into the patch? Or is the change to
> presetShapeDefinitions.xml sufficient and there is a way to run the script
> afterwards?

It's perfectly fine to do this in two commits if you prefer that. If you
just change presetShapeDefinitions.xml, then I think nothing will change
in practice; but separating your real change and the generated changes
make sense.

Tracking the generated file in git is needed because of the circular
dependency here: to generate the file, you need a working installation
set, but to create the installation set, first you need to generate the
file. :-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20190517/ebd729ce/attachment.sig>

More information about the LibreOffice mailing list