Update of file oox-drawingml-cs-presets

Regina Henschel rb.henschel at t-online.de
Sun May 19 14:00:30 UTC 2019

Hi Miklos,

Miklos Vajna schrieb am 17-May-19 um 17:53:
> Hi Regina,
> On Fri, May 17, 2019 at 05:00:02PM +0200, Regina Henschel <rb.henschel at t-online.de> wrote:
>> to fix https://bugs.documentfoundation.org/show_bug.cgi?id=125181 it is
>> needed to correct the file
>> oox/source/drawingml/customshapes/presetShapeDefinitions.xml.
> IIRC that file is from the OOXML spec, so please double-check that you
> indeed have to change it.
>> Do I need to include all changed files into the patch? Or is the change to
>> presetShapeDefinitions.xml sufficient and there is a way to run the script
>> afterwards?
> It's perfectly fine to do this in two commits if you prefer that. If you
> just change presetShapeDefinitions.xml, then I think nothing will change
> in practice; but separating your real change and the generated changes
> make sense.
> Tracking the generated file in git is needed because of the circular
> dependency here: to generate the file, you need a working installation
> set, but to create the installation set, first you need to generate the
> file. :-)

I have put it into patch https://gerrit.libreoffice.org/#/c/72552/ now 
and add you for review. If that is not OK for you please remove you.

I have put both files into the commit. The (now solved *) problem for me 
was, that the script does not work in Cygwin, but needs a true Linux. 
But I had no Gerrit access from Linux in my VM to commit it from there.

* If you move your keys from Cygwin to a .ssh folder in Linux, you have 
to use chmod 600 on the key files.

Kind regards

More information about the LibreOffice mailing list