remove attribute table:cell-range-address at <chart:plot-area> element in ODF 1.4

Eike Rathke erack at redhat.com
Thu Apr 2 12:50:08 UTC 2020


Hi Regina,

On Tuesday, 2020-03-31 16:56:59 +0200, Regina Henschel wrote:

> Does anyone know, whether there exists a scenario (besides sx* import
> filter) where it makes a difference for LibreOffice, whether the attribute
> exists or not?

Of the places that  git grep -w XML_CELL_RANGE_ADDRESS   lists there may
be one of interest

xmloff/source/chart/SchXMLImport.cxx
SchXMLImportHelper::GetPlotAreaAttrTokenMap() has

    { XML_NAMESPACE_TABLE,  XML_CELL_RANGE_ADDRESS,     XML_TOK_PA_CHART_ADDRESS     },

XML_TOK_PA_CHART_ADDRESS is used in
xmloff/source/chart/SchXMLPlotAreaContext.cxx
SchXMLPlotAreaContext::StartElement() to set mrChartAddress and
m_rbHasRangeAtPlotArea = true (that both are references, so wherever
used outside..) and m_rbHasRangeAtPlotArea being true _may_ lead to an
internal data provider not being created as a last fallback further
down.

I don't know of the consequences or how things are later used from there.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20200402/b1153e2f/attachment.sig>


More information about the LibreOffice mailing list