New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1461388:  Error handling issues  (CHECKED_RETURN)
/sd/source/ui/animations/CustomAnimationList.cxx: 482 in sd::CustomAnimationList::DragBeginHdl(bool &)()


________________________________________________________________________________________________________
*** CID 1461388:  Error handling issues  (CHECKED_RETURN)
/sd/source/ui/animations/CustomAnimationList.cxx: 482 in sd::CustomAnimationList::DragBeginHdl(bool &)()
476             mDndEffectsSelected.emplace_back(mxTreeView->make_iterator(&rEntry));
477             return false;
478         });
479     
480         // Note: pEntry is the effect with focus (if multiple effects are selected)
481         mxDndEffectDragging = mxTreeView->make_iterator();
>>>     CID 1461388:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "get_cursor" without checking return value (as is done elsewhere 37 out of 41 times).
482         mxTreeView->get_cursor(mxDndEffectDragging.get());
483         mxDndEffectInsertBefore = mxTreeView->make_iterator(mxDndEffectDragging.get());
484     
485         // Allow normal processing.
486         return false;
487     }

** CID 1461387:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/unoobj/textuno.cxx: 900 in ScCellTextObj::~ScCellTextObj()()


________________________________________________________________________________________________________
*** CID 1461387:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/unoobj/textuno.cxx: 900 in ScCellTextObj::~ScCellTextObj()()
894     ScCellTextObj::ScCellTextObj(ScDocShell* pDocSh, const ScAddress& rP) :
895         ScCellTextData( pDocSh, rP ),
896         SvxUnoText( GetOriginalSource(), ScCellObj::GetEditPropertySet(), uno::Reference<text::XText>() )
897     {
898     }
899     
>>>     CID 1461387:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
900     ScCellTextObj::~ScCellTextObj() throw()
901     {
902     }
903     

** CID 1461386:  Error handling issues  (CHECKED_RETURN)
/sd/source/ui/animations/CustomAnimationList.cxx: 1103 in _ZZNK2sd19CustomAnimationList12getSelectionB5cxx11EvENKUlRN4weld8TreeIterEE_clES3_()


________________________________________________________________________________________________________
*** CID 1461386:  Error handling issues  (CHECKED_RETURN)
/sd/source/ui/animations/CustomAnimationList.cxx: 1103 in _ZZNK2sd19CustomAnimationList12getSelectionB5cxx11EvENKUlRN4weld8TreeIterEE_clES3_()
1097     
1098             // if the selected effect is not expanded and has children
1099             // we say that the children are automatically selected
1100             if (!mxTreeView->get_row_expanded(rEntry) && mxTreeView->iter_has_child(rEntry))
1101             {
1102                 std::unique_ptr<weld::TreeIter> xChild = mxTreeView->make_iterator(&rEntry);
>>>     CID 1461386:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "iter_children" without checking return value (as is done elsewhere 37 out of 39 times).
1103                 mxTreeView->iter_children(*xChild);
1104     
1105                 do
1106                 {
1107                     if (!mxTreeView->is_selected(*xChild))
1108                     {

** CID 1461385:  Error handling issues  (CHECKED_RETURN)
/vcl/source/bitmap/bitmap.cxx: 329 in Bitmap::ImplMakeUnique()()


________________________________________________________________________________________________________
*** CID 1461385:  Error handling issues  (CHECKED_RETURN)
/vcl/source/bitmap/bitmap.cxx: 329 in Bitmap::ImplMakeUnique()()
323     void Bitmap::ImplMakeUnique()
324     {
325         if (mxSalBmp && mxSalBmp.use_count() > 1)
326         {
327             std::shared_ptr<SalBitmap> xOldImpBmp = mxSalBmp;
328             mxSalBmp = ImplGetSVData()->mpDefInst->CreateSalBitmap();
>>>     CID 1461385:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "Create" without checking return value (as is done elsewhere 4 out of 5 times).
329             mxSalBmp->Create(*xOldImpBmp);
330         }
331     }
332     
333     void Bitmap::ReassignWithSize(const Bitmap& rBitmap)
334     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPklAc1eEA-2F1zfUjH6teExViPHTTReBArhCRZ3BE4kCjKjDqn2Dq3ZyEbAvAs31gRpU3vMPHDnoSx68vDAWjNU-3D-kXS_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJifVxcoG0A5GoPBbA567qw4NnZ-2F3BiwqSItoPxW5jeZ2wSizx9sOjXW8P0CyfH-2BOZCLWFZVBcQqjKJDApVX30hAqECGtmu5yKGL-2FKDXomW1LStT1U3D-2BGm7CxInlEW87zlraE5BuKwruOcP8ij5QsKR1fD6T-2BKx-2BuYnbUiqvzVaqE-3D