New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1462267:  Program hangs  (INFINITE_LOOP)
/soltools/cpp/_eval.c: 730 in tokval()


________________________________________________________________________________________________________
*** CID 1462267:  Program hangs  (INFINITE_LOOP)
/soltools/cpp/_eval.c: 730 in tokval()
724                     }
725                     else
726                         if (*p == 'x')
727                         {
728                             p += 1;
729                             i = digit(*p);
>>>     CID 1462267:  Program hangs  (INFINITE_LOOP)
>>>     Top of the loop.
730                             while (i >= 0 && i <= 15)
731                             {
732                                 p += 1;
733                                 n <<= 4;
734                                 n += i;
735                             }

** CID 1462266:  Control flow issues  (DEADCODE)
/sc/source/ui/view/dbfunc3.cxx: 150 in ScDBFunc::TestRemoveOutline(bool &, bool &)()


________________________________________________________________________________________________________
*** CID 1462266:  Control flow issues  (DEADCODE)
/sc/source/ui/view/dbfunc3.cxx: 150 in ScDBFunc::TestRemoveOutline(bool &, bool &)()
144                 if ( !bRowMarked || bColMarked )        // not when entire rows are marked
145                 {
146                     ScOutlineArray& rArray = pTable->GetColArray();
147                     ScSubOutlineIterator aColIter( &rArray );
148                     while (bColFound)
149                     {
>>>     CID 1462266:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "pEntry = aColIter.GetNext();".
150                         pEntry=aColIter.GetNext();
151                         if (!pEntry)
152                             break;
153                         nStart = pEntry->GetStart();
154                         nEnd   = pEntry->GetEnd();
155                         if ( nStartCol<=static_cast<SCCOL>(nEnd) && nEndCol>=static_cast<SCCOL>(nStart) )

** CID 1462265:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/source/gdi/impgraph.cxx: 353 in ImpSwapFile::~ImpSwapFile()()


________________________________________________________________________________________________________
*** CID 1462265:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/source/gdi/impgraph.cxx: 353 in ImpSwapFile::~ImpSwapFile()()
347         maMetaFile.Clear();
348         mpAnimation.reset();
349         mpGfxLink.reset();
350         maVectorGraphicData.reset();
351     }
352     
>>>     CID 1462265:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::DeploymentException" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
353     ImpSwapFile::~ImpSwapFile()
354     {
355         utl::UCBContentHelper::Kill(aSwapURL.GetMainURL(INetURLObject::DecodeMechanism::NONE));
356     }
357     
358     void ImpGraphic::ImplSetPrepared(bool bAnimated, const Size* pSizeHint)

** CID 1462264:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/gfxlink.cxx: 50 in GfxLink::GfxLink(std::unique_ptr<unsigned char [], std::default_delete<unsigned char []>>, unsigned int, GfxLinkType)()


________________________________________________________________________________________________________
*** CID 1462264:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/gfxlink.cxx: 50 in GfxLink::GfxLink(std::unique_ptr<unsigned char [], std::default_delete<unsigned char []>>, unsigned int, GfxLinkType)()
44         , mnSwapInDataSize(nSize)
45         , mbPrefMapModeValid(false)
46         , mbPrefSizeValid(false)
47     {
48         SAL_WARN_IF(mpSwapInData == nullptr || mnSwapInDataSize <= 0, "vcl",
49                     "GfxLink::GfxLink(): empty/NULL buffer given");
>>>     CID 1462264:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "maHash" is not initialized in this constructor nor in any functions that it calls.
50     }
51     
52     size_t GfxLink::GetHash() const
53     {
54         if (!maHash)
55         {

** CID 708596:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/gfxlink.cxx: 36 in GfxLink::GfxLink()()


________________________________________________________________________________________________________
*** CID 708596:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/gfxlink.cxx: 36 in GfxLink::GfxLink()()
30         : meType(GfxLinkType::NONE)
31         , mnUserId(0)
32         , mnSwapInDataSize(0)
33         , mbPrefMapModeValid(false)
34         , mbPrefSizeValid(false)
35     {
>>>     CID 708596:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "maHash" is not initialized in this constructor nor in any functions that it calls.
36     }
37     
38     
39     
40     GfxLink::GfxLink(std::unique_ptr<sal_uInt8[]> pBuf, sal_uInt32 nSize, GfxLinkType nType)
41         : meType(nType)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPklAc1eEA-2F1zfUjH6teExViPHTTReBArhCRZ3BE4kCjKjDqn2Dq3ZyEbAvAs31gRpU3vMPHDnoSx68vDAWjNU-3Dl4ub_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJic1ARa0QbSBPFgc9x7ibM6juifZBE8BnUecteaLGSfLqNsljIUjQqtTMxB1El-2FlOgOHTB-2Foxo9J4-2FffRz3juDdrMCChN00CDKlbAGFaPc3yocjiP82g8oyT9UdFiLx976zXtMmwzMEHJFL5QN82mW786DqCwgbUzInXoHskkI-2BXQ7CcGBkWJAQZJMCReta3RX