New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1466206:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/fontsubset/sft.cxx: 1482 in vcl::TrueTypeFont::TrueTypeFont(const char *)()


________________________________________________________________________________________________________
*** CID 1466206:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/fontsubset/sft.cxx: 1482 in vcl::TrueTypeFont::TrueTypeFont(const char *)()
1476         , subfamily(nullptr)
1477         , usubfamily(nullptr)
1478         , ntables(0)
1479         , cmap(nullptr)
1480         , cmapType(0)
1481     {
>>>     CID 1466206:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mapper" is not initialized in this constructor nor in any functions that it calls.
1482     }
1483     
1484     TrueTypeFont::~TrueTypeFont()
1485     {
1486     #if !defined(_WIN32)
1487         if (fileName())

** CID 1466205:  Control flow issues  (DEADCODE)
/sc/source/ui/drawfunc/fuins1.cxx: 414 in FuInsertMedia::FuInsertMedia(ScTabViewShell &, vcl::Window *, ScDrawView *, SdrModel *, const SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1466205:  Control flow issues  (DEADCODE)
/sc/source/ui/drawfunc/fuins1.cxx: 414 in FuInsertMedia::FuInsertMedia(ScTabViewShell &, vcl::Window *, ScDrawView *, SdrModel *, const SfxRequest &)()
408         if( !::avmedia::MediaWindow::isMediaURL( aURL, ""/*TODO?*/, true, &aPrefSize ) )
409         {
410             if( pWin )
411                 pWin->LeaveWait();
412     
413             if( !bAPI )
>>>     CID 1466205:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "executeFormatErrorBox" inside this statement: "avmedia::MediaWindow::execu...".
414                 ::avmedia::MediaWindow::executeFormatErrorBox(pWindow ? pWindow->GetFrameWeld() : nullptr);
415         }
416         else
417     #endif
418         {
419             lcl_InsertMedia( aURL, bAPI, &rViewSh, pWindow, pView, aPrefSize,

** CID 1466204:  Error handling issues  (CHECKED_RETURN)
/filter/source/msfilter/escherex.cxx: 697 in EscherPropertyContainer::CreateTextProperties(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &, unsigned int, bool, bool)()


________________________________________________________________________________________________________
*** CID 1466204:  Error handling issues  (CHECKED_RETURN)
/filter/source/msfilter/escherex.cxx: 697 in EscherPropertyContainer::CreateTextProperties(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &, unsigned int, bool, bool)()
691         // used with ashapes:
692         bool bWordWrap          ( false );
693         bool bAutoGrowSize      ( false );
694     
695         uno::Any aTextWrap;
696     
>>>     CID 1466204:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "GetPropertyValue" without checking return value (as is done elsewhere 36 out of 37 times).
697         EscherPropertyValueHelper::GetPropertyValue(aTextWrap, rXPropSet, "TextWrap", true);
698     
699         if ( EscherPropertyValueHelper::GetPropertyValue( aAny, rXPropSet, "TextWritingMode", true ) )
700             aAny >>= eWM;
701         if ( EscherPropertyValueHelper::GetPropertyValue( aAny, rXPropSet, "TextVerticalAdjust", true ) )
702             aAny >>= eVA;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DQJFt_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJitL6hbzJTuudawmxwn8rYJ9nhUe6GxyteRKPfywzEybGxoKlEGgqBLishMpMhTdLDd9B-2BLNZK7NoZKFAjVaKZiwk9HhJOfh2TGm-2BPJnwD50IgFNMxmaosMXl9Ssv0nQ2HscQ-2BtBlQ8vzRhvQGf1QZZzcJvw3a51Y7vIqn-2F3i1Xd9eTh9MCkyG8CqCVccsBbol