Patch review

Ilmari Lauhakangas ilmari.lauhakangas at libreoffice.org
Tue Nov 10 14:30:38 UTC 2020


anshu khare kirjoitti 10.11.2020 klo 16.27:
> Hi
> 
> Please review my patch
> 
> https://gerrit.libreoffice.org/c/core/+/105501
> 
> I have tested it. It's working fine.
> Please merge it.

You did not address Jim's comment:
"Please see 
https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf#1967986
I think this is the reason for diff showing all lines have been changed."

You have to fix this problem and amend your patch: 
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch#Submitting_a_new_version

Ilmari


More information about the LibreOffice mailing list