pointers for updating tests after changing PDF export defaults

[Stéphane Guillou]

Hi all!

Just sending my question here because I can never seem to catch other 
developers on IRC, probably because of time zones.

I am working on this easyhack bug/enhancement: 
https://bugs.documentfoundation.org/show_bug.cgi?id=39667

The change I am proposing is very small (changing two default values in 
the PDF settings, see the attached diff), but changing the default PDF 
export settings expectedly makes some tests fail (details attached).

Specifically, what I am wondering is:

  * when asserting an equality, e.g.:
    CPPUNIT_ASSERT_EQUAL(OString("Im19"), rIDs[0])
    <https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#2268>
      o what do strings like "Im19" or "Im12" mean in these contexts?
  * what is the "W array" that is not found in: CPPUNIT_ASSERT(pWArray)
    <https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#2661>
  * why could it be that rDocument.Read() fails at:
    CPPUNIT_ASSERT(rDocument.Read(aStream))
    <https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#912>
    (in the load function)

Is there someone with more knowledge about tests and PDFs who could put 
me on the right path?

Thanks in advance!

(I am not subscribed to the dev mailing list so please send a reply to 
me as well as the list! 😁)

-- 
Stéphane Guillou
http://stragu.gitlab.io/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20210810/a4d77f8b/attachment.htm>
-------------- next part --------------
pdfexport.cxx:2268:Assertion
Test name: (anonymous namespace)::testMultiPagePDF::TestBody
equality assertion failed
- Expected: Im19
- Actual  : Im21

https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#2214

file: core/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf

---

pdfexport.cxx:2661:Assertion
Test name: (anonymous namespace)::testReexportDocumentWithComplexResources::TestBody
assertion failed
- Expression: pWArray

https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#2661

File: core/vcl/qa/cppunit/pdfexport/data/ComplexContentDictionary.pdf

---

pdfexport.cxx:2451:Assertion
Test name: (anonymous namespace)::testReexportPDF::TestBody
equality assertion failed
- Expected: Im12
- Actual  : Im14

https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#2451

File: core/vcl/qa/cppunit/pdfexport/data/PDFWithImages.pdf

---

pdfexport.cxx:135:Assertion
Test name: (anonymous namespace)::testTdf118244_radioButtonGroup::TestBody
assertion failed
- Expression: rDocument.Read(aStream)

Bug: https://bugs.documentfoundation.org/show_bug.cgi?id=118244

Load function fails CPP_ASSERT in test:
https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#912

Load function (with CPP_ASSERT) defined here:
https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx?r=4390f233&mo=95984&fi=2214#135

File: core/vcl/qa/cppunit/pdfexport/data/tdf118244_radioButtonGroup.odt
-------------- next part --------------
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index b5cc8182eb46..98bd67787e54 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -5054,7 +5054,7 @@
               <desc>Determines if PDF are created by using special tags also
               known as Tagged PDF.</desc>
             </info>
-            <value>false</value>
+            <value>true</value>
           </prop>
           <prop oor:name="ExportNotes" oor:type="xs:boolean" oor:nillable="false">
             <info>
@@ -5463,7 +5463,7 @@
             <info>
               <desc>Specifies if the document is PDF/UA (Universal Accessibility) compliant</desc>
             </info>
-            <value>false</value>
+            <value>true</value>
           </prop>
           <!-- END PDF/UA Compliance -->
           <!-- PDF Relative Link -->