ESC meeting minutes: 2022-08-18

Miklos Vajna vmiklos at collabora.com
Thu Aug 18 14:49:15 UTC 2022


* Present:
     + Michael W, Ilmari, Hossein, Olivier, Caolan, Cloph, Miklos, Xisco, Stephan, Heiko, Michael S, Eike, Gabriel, Thorsten, Lubos

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
     + 7.4 status: announced as final today
       + 7.4.1 rc1 in 1 week
     + 7.3 status: 7.3.6 rc1 this week
     + Appstores
       + Windows: need to change the packaging format, waiting for MS
       + Mac: that is waiting till the Windows side is ready
     + recently we have seen nice fixes for CTL/RTL from Khaled (Hossein)
       + are these backported to stable branches?
       + think there were 5 or 6 patches (Xisco)
         + backported 1, wanted to backport 2 more, but Khaled suggests to bake them on master for now
         + so most of these will be in 7.5

* Documentation (Olivier)
      + New Help
      + Helcontent2
         + Updates and fixes (ohallot)
      + Guides
         + Published Base Guide 7.3 Final (ohallot, flywire)
         + Calc Guide 7.4 ready for publication (Skip Masonsmith, K. Kriek, ohallot)
      + Bugzilla Documentation statistics
          239(239) bugs open
      + Updates:
          BZ changes   1 week    1 month   3 months   12 months
             created      8(-11)   31(3)      90(-1)     333(3)
           commented     10(-10)   50(4)     276(-8)    1470(-4)
            resolved      1(-9)    12(-2)     42(-1)     214(-1)
      + top 10 contributors:
            Olivier Hallot made 47 changes in 1 month, and 499 changes in 1 year
            Kaganski, Mike made 23 changes in 1 month, and 115 changes in 1 year
            Seth Chaiklin made 12 changes in 1 month, and 342 changes in 1 year
            Rafael Lima made 9 changes in 1 month, and 306 changes in 1 year
            Dieter made 6 changes in 1 month, and 99 changes in 1 year
            Robert Großkopf made 6 changes in 1 month, and 15 changes in 1 year
            Roman Kuznetsov made 5 changes in 1 month, and 26 changes in 1 year
            Justin Luth made 4 changes in 1 month, and 11 changes in 1 year
            Balland-Poirier, Laurent made 3 changes in 1 month, and 3 changes in 1 year
            Nabet, Julien made 3 changes in 1 month, and 92 changes in 1 year

* UX Update (Heiko)
      + Bugzilla (topicUI) statistics
          269(269) (topicUI) bugs open, 54(54) (needsUXEval) needs to be evaluated by the UXteam
      + Updates:
          BZ changes   1 week    1 month    3 months   12 months
               added      6(0)      11(3)      12(2)       37(2)
           commented     43(-16)   164(-22)   452(-29)   2174(-51)
             removed      1(1)       1(1)       2(1)       28(-1)
            resolved      5(0)      23(0)      71(0)      315(-5)
      + top 10 contributors:
            Heiko Tietze made 98 changes in 1 month, and 1538 changes in 1 year
            Roman Kuznetsov made 31 changes in 1 month, and 168 changes in 1 year
            Dieter made 26 changes in 1 month, and 217 changes in 1 year
            Rafael Lima made 25 changes in 1 month, and 106 changes in 1 year
            Timur made 24 changes in 1 month, and 79 changes in 1 year
            Eyal Rozenberg made 18 changes in 1 month, and 94 changes in 1 year
            Bielefeld, Rainer made 11 changes in 1 month, and 19 changes in 1 year
            Tavo made 9 changes in 1 month, and 9 changes in 1 year
            Foote, V Stuart made 9 changes in 1 month, and 229 changes in 1 year
            m.a.riosv made 8 changes in 1 month, and 16 changes in 1 year
     + new tickets
       + [Bug 150461] Allow deselecting tables in View->Tables
       + [Bug 150448] Preview using Conditional Formatting has weird behavior when
              multiple cells are selected
   ->  + [Bug 150428] Document Recovery UX can be improved
         + technical input on this one is welcome in the bugreport
       + [Bug 135460] BORDERS TAB IN PARAGRAPH DIALOG: Make selection of borders
              in User-defined preview more visible (see comment 7)
       + [Bug 120615] Ctrl+LShift, Ctrl+RShift not setting direction in Impress
       + [Bug 150375] Render non-printing line numbers with faint gray

     + attention required
   ->  + Paragraph mark in rotated-character paragraph placed in middle of text
         + https://bugs.documentfoundation.org/show_bug.cgi?id=150276
         + inconsistency with MSO how rotated text is handled with line breaks
         + over-painting feels just buggy, it's more about a matter of who has time to improve this, keeping backwards compat in mind (Miklos)
         + when the whole document is rotated, we have one behavior (Caolan)

               + would be good to follow that behavior in the rotated-text-portion case as well

               + vertical text direction on page style is available if CJK is enabled in options



     + potential easy hacks
   ->  + Render non-printing line numbers with faint gray
         + https://bugs.documentfoundation.org/show_bug.cgi?id=150375
   ->  + Last row does not remain hidden when deleting row(s)
         + https://bugs.documentfoundation.org/show_bug.cgi?id=150260


* Crash Testing (Caolan)
      + 193(+58) import failure, 164(+70) export failures
        - many actually fixed, but new assert > num fixed
      + validation is now switched off to get faster results, for now
      + 313 coverity issues, due to a new coverity version
        - new false positive noisy version
      + 10 ossfuzz issues
        - 1 crash, 1 leak, 3 OOM, 6 timeouts

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.2.7.2
          + (-10) 502 512 516 479 484 410 396 382 314 268 167 0
    + https://crashreport.libreoffice.org/stats/version/7.3.4.2
          + (-196) 1248 1498 1695 1672 1581 1128 963 675 0
    + https://crashreport.libreoffice.org/stats/version/7.3.5.2
          + (+316) 1196 866 550 0

     + https://crashreport.libreoffice.org/stats/signature/mdds::flat_segment_tree%3Clong,bool%3E::insert_to_pos(boost::intrusive_ptr%3Cmdds::__st::node%3Cmdds::flat_segment_tree%3Clong,bool%3E%20%3E%20%3E%20&,long,long,bool)

     - Most reported crash in all 7.3.x versions

     - Finally steps to reprodude reported in https://bugs.documentfoundation.org/show_bug.cgi?id=150170

     - in master and 7.4. fixed by lubos' work on increasing the default number of columns

     - problematic patch reverted in libreoffice-7-3 only


     + Regression in 7.3.5.2

         - https://crashreport.libreoffice.org/stats/signature/vcl::Window::IsVisible()%20const

         - https://bugs.documentfoundation.org/show_bug.cgi?id=150242 - crash saving document. no steps to reproduce it though

         - related to https://bugs.documentfoundation.org/show_bug.cgi?id=147708 ?


* mentoring/easyhack update
            committer...   1 week    1 month     3 months    12 months
                    open      65(-6)    120(-4)     133(-2)      133(-2)
                 reviews     408(44)   1270(114)   2996(96)    12186(-70)
                  merged     280(-5)   1039(118)   3324(-48)   15151(18)
               abandoned      16(7)      48(0)      156(-1)      786(-20)
             own commits     208(2)     763(102)   2336(-43)   11770(1)
          review commits      45(20)    193(12)     589(-4)     3292(-27)
          contributor...   1 week    1 month     3 months    12 months
                    open      65(-6)    125(20)     134(16)      139(16)
                 reviews     852(4)    2776(270)   7622(18)    33206(-32)
                  merged      24(7)     111(9)      214(17)     1201(-10)
               abandoned       3(-7)     22(-17)     97(-11)     432(-24)
             own commits      17(7)      80(7)      181(7)      1213(-11)
          review commits       0(0)       0(0)        0(0)         0(0)
      + easyHack statistics:
         needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 301(301)
         total 364(364)   assigned 16(16)   open 318(318)
      + top 10 contributors:
            Paris Oplopoios made 34 patches in 1 month, and 53 patches in 1 year
            خالد حسني made 13 patches in 1 month, and 14 patches in 1 year
            Hannah Meeks made 10 patches in 1 month, and 19 patches in 1 year
            Colomban Wendling made 6 patches in 1 month, and 9 patches in 1 year
            Srebotnjak, Martin made 2 patches in 1 month, and 24 patches in 1 year
            Ehsan Movahedian made 2 patches in 1 month, and 4 patches in 1 year
            Nagy Tibor made 1 patches in 1 month, and 27 patches in 1 year
            Matt K made 1 patches in 1 month, and 2 patches in 1 year
            Radhey Parekh made 1 patches in 1 month, and 3 patches in 1 year
            Isha Desai made 1 patches in 1 month, and 3 patches in 1 year
      + top 10 reviewers:
            Vajngerl, Tomaž made 176 review comments in 1 month, and 406 in 1 year
            McNamara, Caolán made 110 review comments in 1 month, and 620 in 1 year
            Nabet, Julien made 104 review comments in 1 month, and 696 in 1 year
            Michael Stahl made 104 review comments in 1 month, and 1196 in 1 year
            Thorsten Behrens made 96 review comments in 1 month, and 852 in 1 year
            Xisco Fauli made 80 review comments in 1 month, and 932 in 1 year
            Adolfo Jayme Barrientos made 74 review comments in 1 month, and 1064 in 1 year
            Kaganski, Mike made 64 review comments in 1 month, and 646 in 1 year
            Grandin, Noel made 38 review comments in 1 month, and 386 in 1 year
            Hossein made 38 review comments in 1 month, and 252 in 1 year
      + Patches automatically abandoned:
          WIP: tdf#124098: sc: new document setting "ForceRowHeightRecalc" ( Vasily Melenchuk )
              - https://gerrit.libreoffice.org/#/c/129300
              - Restored, issue status: NEW
          tdf#89387 Use Parallel Walk to improve Matrix Operations ( Sarrah Bastawala )
              - https://gerrit.libreoffice.org/#/c/132453
              - Restored, contacted the author of the patch
          vcl: always delegate calls to SalGraphicsImpl - removes cruft ( Tomaž Vajngerl )
              - https://gerrit.libreoffice.org/#/c/132908
          tdf#149252  update help for Entire Paragraph Area positioning ( Seth Chaiklin )
              - https://gerrit.libreoffice.org/#/c/135008
              - Author says: "I am not able to devote more time to this patch".
          Fill Rule next ( Bartosz Kosiorek )
              - https://gerrit.libreoffice.org/#/c/135596
              - WIP, not yet finished
          WIN convert un-maxmize handling ( Jan-Marek Glogowski )
              - https://gerrit.libreoffice.org/#/c/135812
      + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
            Thierry Emery
            wu jiahuan (loongson.cn)

Discussions:
     1. The precision of std functions for double (reverse hyperbolic functions)
        Use std functions instead of our own implementation
        https://bugs.documentfoundation.org/show_bug.cgi?id=148430
        + at least need to keep internal implementation (Eike)
          + we just don't know how precise the std {asinh,acosh} implementations are for the different platforms
          + don't be confused: the displayed precision may be different from what is stored internally (need to compare binary values)
          + need to also care about existing documents
          + best to just close the easyhack
     2. Review bot, abondoning previously restored patches
       + proposed idea: if a patch is restored once, don't abandon it again (Hossein)
       + don't like the idea (Cloph)
         + it's not enough to just comment to keep it alive, could require at least a rebase
         + to avoid changes stay around forever
         + suggest to not bother with this
         + we already recommend to not submit too old patches, more then 1 week old (Miklos)
         + an option is introduce a magic label on the change to avoid garbage collection (Cloph)
           + easiest is to not do anything for now

* GSoC (Hossein/Ilmari)
   + Timeline: https://developers.google.com/open-source/gsoc/timeline
   + work is ongoing (Ilmari)

* Commit Access

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 27 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
     from:Thu Aug 11 13:55:28 2022
     master linux rel  jobs: 120 ok: 120 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master linux dbg  jobs: 101 ok:  92 ko:   9 fail ratio:  8.91 % break:   7 broken duration: 7.55%
     master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master win rel    jobs:  79 ok:  54 ko:  25 fail ratio: 31.65 % break:  13 broken duration:32.39%
     master win dbg    jobs:  80 ok:  80 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master win64 dbg  jobs:  81 ok:  81 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master gerrit lin jobs: 628 ok: 490 ko: 114 fail ratio: 18.15% time for ok: mean:  22 median:  19
     master gerrit plg jobs: 567 ok: 399 ko: 129 fail ratio: 22.75% time for ok: mean:  44 median:  43
     master gerrit win jobs: 655 ok: 433 ko: 183 fail ratio: 27.94% time for ok: mean:  57 median:  54
     master gerrit mac jobs: 613 ok: 449 ko:  83 fail ratio: 13.54% time for ok: mean:  36 median:  34
     master android    jobs: 557 ok: 503 ko:  28 fail ratio:  5.03% time for ok: mean:  26 median:  20
     master gerrit all jobs: 576 ok: 291 ko: 206 fail ratio: 35.76% time for ok: mean: 163 median: 132
    + https://dev-www.libreoffice.org/tmp/gerrit_220818.html
    + tests that failed more than twice in last seven days
       3 CppunitTest_sc_shapetest                gerrit_windows
       3 CppunitTest_sw_odfimport                gerrit_linux_clang_dbgutil
       3 CppunitTest_sw_uiwriter6                gerrit_mac
       3 CppunitTest_vcl_pdfexport                gerrit_linux_gcc_release
       3 UITest_writer_tests4                gerrit_linux_clang_dbgutil
       4 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
       4 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil_branch
       4 CppunitTest_sw_uiwriter6                gerrit_windows
       4 CppunitTest_vcl_pdfexport                gerrit_mac
       5 CppunitTest_chart2_export                gerrit_linux_gcc_release
       6 UITest_calc_tests8                gerrit_linux_clang_dbgutil
       6 UITest_impress_tests2                gerrit_linux_clang_dbgutil
      11 CppunitTest_sal_osl_security                gerrit_mac (bad bot)
      16 CppunitTest_sc_vba_macro_test                gerrit_windows (bad bot)
      + this week is getting back to normal (Cloph)
      + resuming of builds were broken, now fixed
      + had a Windows and a macOS bot problem, already fixed
      + we're still low on macs, but compensating it with some cloud workers
        + also tried pch for macOS, but it didn't help too much, Intel build even got slower
      + MSP perl code removed? (Miklos)
        + feel free to restore it if it's used (Cloph)
          + currently uses a weak hash, though

* Table style improvement task was budgeted for this year, but doubts appeared (Ilmari)
   + https://wiki.documentfoundation.org/Development/Budget2022#Table_Styles_improvements
   + Mike K. recommends to invest in implementing it properly rather
     than continue to tweak the current solution that relies on direct
     formatting
     + implemented as GSoC in 2016 - our current solution
     + which is not using the actual styles machinery
     + but instead using hard formatting
   + so the better plan would be to implement it based on real styles
   + lets wait for Miklos' feedback on this (Caolan)
     + re-visit after his vacation next week
     + support the idea, but it’s hard to know how much effort would it to get rid of the direct-formatting-based approach, see <https://bugs.documentfoundation.org/show_bug.cgi?id=126008#c50> for details (Miklos)
       + agreeing in general

* What’s cooking (Miklos)
   + feature/chartdatatable: MSO-style data tables for charts (Tomaz): work can be tested on master

  * settings AllowEditReadonlyDocs and AllowOverrideLocking seem to be set
    to true by default (Heiko)
    + https://bugs.documentfoundation.org/show_bug.cgi?id=150436
    + AllowEditReadonlyDocs = true shows the "Edit" button in the infobar,
      which is hidden when false
    + unsafe and users don't understand the consequences (Winfried)
    + was always like this (Samuel)
    + when you click the button, we check read-write permissions, and you get the dialog (Michael S)
      + at least it worked like this a few months ago

* QA update (Xisco)
      + UNCONFIRMED: 1707 (-7)
          + enhancements: 284  (-2)
          + needsUXEval: 4 (+1)
          + haveBackTrace: 6 (-1)
          + needsDevAdvice: 27 (-1)
          + documentation:  12 (+1)
          + android:  3 (+0)
          + iOS:  0 (+0)
          + Online:  12 (+0)

      + status/plans wrt. https://redmine.documentfoundation.org/issues/3614 ?
        + original plan was to hide it from anonymous users (Xisco)
          + had a problem -> had to revert, so currently anyone can see it
          + will fix it, just need time

      + Most pressing bugs:

     None


      + New high severity bugs of the week:
          + Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
              + https://bugs.documentfoundation.org/show_bug.cgi?id=150236
              + Lubos?
              + happens only in 7.4, Jan-Marek already fixed it on master
              + the change may not be backported as-is
                + will check (Stephan)

          + Shift + Up/Left no longer works to select cells in LO 7.4 beta 2 (using the Tabbed UI)
              + https://bugs.documentfoundation.org/show_bug.cgi?id=150336
              + Tomaz?

          + Track changes: Crash rejecting a grouped change
              + https://bugs.documentfoundation.org/show_bug.cgi?id=150443
              + Laszlo?

* QA stats
      + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
        +126  -36 (-142) overall)
        many thanks to the top bug squashers:
         Mike Kaganski           28
         خالد حسني               24
         + thanks a lot for these fixes! (Hossein)
         Timur                   12
         Julien Nabet            11
         Michael Stahl (allotropia) 7
         QA Administrators       6
         Dieter                  4
         Gabor Kelemen (allotropia) 4
         Heiko Tietze            4
         Xisco Faulí             4

      + top 10 bugs reporters:
         Telesto                 11
         Rafael Lima             4
         Eyal Rozenberg          3
         Gerald Pfeifer          3
         Mike Kaganski           3
         NISZ LibreOffice Team   3
         BogdanB                 2
         Eike Rathke             2
         Faisal                  2
         João Paulo              2

      + top 10 bugs fixers:
         خالد حسني               15
         Nabet, Julien           6
         Michael Stahl           3
         Grandin, Noel           2
         Heiko Tietze            2
         Luboš Luňák             2
         McNamara, Caolán        2
         *UNKNOWN*               1
         Arisha                  1
         Bergmann, Stephan       1

      + top 10 bugs confirmers:
         Timur                   14
         Xisco Fauli             9
         *UNKNOWN*               8
         Rafael Lima             6
         Heiko Tietze            5
         Roman Kuznetsov         5
         Dieter                  4
         m.a.riosv               4
         خالد حسني               4
         Rathke, Eike            3


  * Highest-Priority bugs (aka "MABs"):
     + http://bit.ly/2lJAAJI
       6.0 : 1/53 -     1 %  (+0)
       5.4 : 0/41 -     0 %  (+0)
       5.3 : 0/54 -     0 %  (+0)
       5.2 : 0/43 -     0 %  (+0)
       5.1 : 1/36 -     2 %  (+0)
       5.0 : 0/64 -     0 %  (+0)
       4.4 : 0/76 -     0 %  (+0)
       4.3 : 0/73 -     0 %  (+0)
       4.2 : 2/134 -    1 %  (+0)
       4.1 : 3/85 -     3 %  (+0)
       4.0 : 2/83 -     2 %  (+0)
       old : 1/246 -    0 %  (+0)


  * Bisected bugs open: keyword 'bisected'
     + more accurate - down to a single commit.
     + http://bit.ly/2dyIfDy
     +

       done by:
          Raal                   5
          Xisco Fauli            2
          Roman Kuznetsov        1
          Kelemen, Gabor         1
          Kaganski, Mike         1
          Stéphane Guillou       1
          Timur                  1


  * Bibisected bugs open: keyword 'bibisected'
     + http://bit.ly/2cSCXlS
     +

       done by:
          Raal                   5
          Xisco Fauli            2
          Roman Kuznetsov        1
          Kelemen, Gabor         1
          Kaganski, Mike         1
          Stéphane Guillou       1
          Timur                  1


  * all bugs tagged with 'regression'
     + 1201(-7) bugs open of 11938(+12) total 10(+0) high prio.

       done by:
          Telesto                3
          Raal                   2
          Xisco Fauli            2
          Kaganski, Mike         1
          sclewell               1
          Timur                  1
          Foote, V Stuart        1


  * ~Component   count net * high severity regressions
     + http://bit.ly/1HWHb3E
       Writer        - 6(+0)
       Calc          - 1(+0)
       Draw          - 1(+0)
       Impress       - 1(+0)
       LibreOffice   - 1(+0)

     by OS:
       All           - 9(+0)
       Linux         - 0(+0)
       Mac OS X      - 0(+0)
       Windows       - 1(+0)


  * ~Component   count net * all regressions
     + http://bit.ly/1BUdI8i
       Writer: other            - 431(-3)
       Calc                     - 197(+2)
       Impress                  - 117(-1)
       Writer: docx filter      - 57(-1)
       Crashes                  - 53(-3)
       LibreOffice              - 46(-1)
       Draw                     - 45(-2)
       UI                       - 41(+0)
       Writer: perf             - 36(+0)
       Borders                  - 35(+0)
       Base                     - 32(+0)
       Writer: other filter     - 32(+0)
       RTL                      - 24(+0)
       Chart                    - 23(+0)
       Writer: doc filter       - 21(+0)
       BASIC                    - 18(+0)
       Printing and PDF export  - 18(+0)
       filters and storage      - 15(+0)
       graphics stack           - 13(-1)
       Formula Editor           - 3(+0)
       framework                - 2(+0)
       Linguistic               - 1(+0)
       sdk                      - 1(+0)


More information about the LibreOffice mailing list