ESC meeting minutes: 2022-12-08

Miklos Vajna vmiklos at collabora.com
Thu Dec 8 15:30:51 UTC 2022


* Present:
     + Caolan, Cloph, Heiko, Ilmari, Hossein, Stephan, Xisco, Gabriel, Miklos, Michael S, Stephane, Eike, Kendy

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
     + 7.4 status: 7.4.4 rc1 in 1 week
     + 7.5 status:
       + issue building install sets on Windows, still investigating
       + feature freeze this week week, also means the beta1 and -7-5 branch
          + (but can still +2 yourself for now)
          + to be tagged later today
       + no late features are known at this time
         + have pending patch on master (Michael S)
           + around PDF/UA, adding checkbox to the UI
         + fine, UI freeze is only with RC1

* Documentation (Olivier)(not available)
     + New Help
        + No news
     + Helpcontents2
        + Housekeeping, removing useless attribute (Ilmari, cloph)
        + Updates and fixes (ohallot, A. Romedenne, B. Buzea, erack, J. Nabet))
     + Guides
        + Work in progress for 7.5 (Skip Masonsmith, flywire, P. Schoffield, J. Weber)
     + Bugzilla Documentation statistics
         247(247) bugs open
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
            created     14(5)     49(3)     90(-4)     322(2)
          commented     16(-7)   157(-4)   288(2)     1214(-5)
           resolved      6(5)     21(3)     42(-2)     202(2)
     + top 10 contributors:
           Bogdan B made 117 changes in 1 month, and 147 changes in 1 year
           Stéphane Guillou (stragu) made 44 changes in 1 month, and 49 changes in 1 year
           Olivier Hallot made 30 changes in 1 month, and 470 changes in 1 year
           Heiko Tietze made 28 changes in 1 month, and 120 changes in 1 year
           Dieter made 18 changes in 1 month, and 87 changes in 1 year
           Ilmari Lauhakangas made 14 changes in 1 month, and 104 changes in 1 year
           Rafael Lima made 14 changes in 1 month, and 229 changes in 1 year
           steve made 11 changes in 1 month, and 18 changes in 1 year
           Kaganski, Mike made 9 changes in 1 month, and 114 changes in 1 year
           Christian Lohmaier made 6 changes in 1 month, and 6 changes in 1 year

* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         279(279) (topicUI) bugs open, 61(61) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
              added      8(4)     11(5)     26(2)       52(3)
          commented     51(9)    177(-5)   509(-37)   2173(-53)
            removed      2(0)      6(0)     10(0)       37(0)
           resolved      3(-6)    30(-5)    81(-7)     313(-11)
     + top 10 contributors:
           Heiko Tietze made 143 changes in 1 month, and 1511 changes in 1 year
           V Stuart Foote made 54 changes in 1 month, and 107 changes in 1 year
           Eyal Rozenberg made 25 changes in 1 month, and 184 changes in 1 year
           Ilmari Lauhakangas made 25 changes in 1 month, and 155 changes in 1 year
           Dieter made 22 changes in 1 month, and 200 changes in 1 year
           Stéphane Guillou (stragu) made 22 changes in 1 month, and 29 changes in 1 year
           Bogdan B made 18 changes in 1 month, and 44 changes in 1 year
           McNamara, Caolán made 12 changes in 1 month, and 33 changes in 1 year
           Hossein made 11 changes in 1 month, and 68 changes in 1 year
           خالد حسني made 11 changes in 1 month, and 24 changes in 1 year
     + 5 new tickets with needsUXEval
       + [Bug 141834] Lines added to bullet list are not animated
       + [Bug 145161] Writer Impress : the image compression form should change the
              image resolution only if it decreases
       + [Bug 146638] In a titlebar, name of a app and the opened document should
              be separated by an emdash, not a hyphen
       + [Bug 152357] Show "more options" symbol also in the tabs
       + [Bug 146609] Width property does not work in right-sidebar via "Position
              and Size" panel
     => needsDevAdvice
       + Settings on the image frame style lost when caption is applied (Writer)
         + https://bugs.documentfoundation.org/show_bug.cgi?id=32485
         + attributes seems to be direct formatted
         + styles need an update for the anchor
       + Lines added to bullet list are not animated (Impress)
         + https://bugs.documentfoundation.org/show_bug.cgi?id=141834
         + list / text box items should be considered a group
       + Provide a visual clue when a table is a DDE link to Calc (Writer)
         + https://bugs.documentfoundation.org/show_bug.cgi?id=75375
         + see also bug 85754 and bug 147233
         + kind of highlighting and handling like fields
         + good task for GSoC

* Crash Testing (Caolan)
     + 22(-2) import failure, 1(+0) export failures
       - downloading a new forum collection first (267,000+)
       - but expect at least one, maybe 2, of existing failures are fixed thanks to Noel
     + 0 coverity issues
     + 4 ossfuzz issues
       - 1 smartart (?) leak https://bugs.documentfoundation.org/show_bug.cgi?id=151930
       - 2 OOM, 1 TimeOut

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.3.6.2
          + (+44) 646 602 631 657 796 797 802 695 605 523 391 313 139 0
    + https://crashreport.libreoffice.org/stats/version/7.3.7.2
          + (+102) 533 431 460 855 217 0
    + https://crashreport.libreoffice.org/stats/version/7.4.2.3
          + (-209) 1537 1746 2048 1986 1732 1632 1253 650 0
    + https://crashreport.libreoffice.org/stats/version/7.4.3.2
          + (+198) 910 712 0

     + Crash fixed in 7.4.3.2

     - SdrLayerIDSet::IsSet(o3tl::strong_int<short,SdrLayerIDTag>)

     - osl_closeFile ( thanks to David Alan Gilbert )

     - static long oox::drawingml::lcl_GetGluePointId(const class com::sun::star::uno::Reference<com::sun::star::drawing::XShape> & const, long & const)

     - osl_getSystemPathFromFileURL_(_rtl_uString *,_rtl_uString * *,bool)

     + No new crashes so far



* Easyhack update / mentoring (Hossein)
           committer...   1 week     1 month     3 months     12 months
                   open      90(12)     152(16)     156(15)       162(16)
                reviews     294(-18)   1192(28)    2864(-42)    11636(-24)
                 merged     242(-36)   1139(-26)   3360(-111)   14558(-97)
              abandoned       6(-6)      58(-11)    174(-19)      847(-10)
            own commits     158(-40)    828(-59)   2531(-105)   11122(-113)
         review commits      40(-4)     279(-33)    765(-23)     2903(-30)
         contributor...   1 week     1 month     3 months     12 months
                   open      25(-6)     188(-27)    191(-31)      207(-31)
                reviews     734(-84)   2894(-42)   7496(-210)   31994(-232)
                 merged      12(-11)    114(-8)     233(-10)     1017(-39)
              abandoned      30(20)      95(25)     141(25)       446(29)
            own commits      19(1)      150(-13)    311(-5)       945(-15)
         review commits       0(0)        0(0)        0(0)          0(0)
     + easyHack statistics:
        needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 315(315)
        total 376(376)   assigned 19(19)   open 327(327)
     + top 10 contributors:
           Bogdan B made 62 patches in 1 month, and 70 patches in 1 year
           Armin Le Grand (allotropia) made 6 patches in 1 month, and 30 patches in 1 year
           Daniel Lohmann made 5 patches in 1 month, and 9 patches in 1 year
           Skyler Grey made 5 patches in 1 month, and 5 patches in 1 year
           Srebotnjak, Martin made 4 patches in 1 month, and 22 patches in 1 year
           Stéphane Guillou made 4 patches in 1 month, and 4 patches in 1 year
           Rashesh Padia made 4 patches in 1 month, and 5 patches in 1 year
           Emanuele Goldoni made 4 patches in 1 month, and 4 patches in 1 year
           Paris Oplopoios made 4 patches in 1 month, and 10 patches in 1 year
           Nick Wingate made 3 patches in 1 month, and 4 patches in 1 year
     + top 10 reviewers:
           Michael Stahl made 106 review comments in 1 month, and 1074 in 1 year
           McNamara, Caolán made 88 review comments in 1 month, and 830 in 1 year
           Vajngerl, Tomaž made 80 review comments in 1 month, and 418 in 1 year
           Adolfo Jayme Barrientos made 70 review comments in 1 month, and 1040 in 1 year
           Németh, László made 64 review comments in 1 month, and 292 in 1 year
           Ilmari Lauhakangas made 60 review comments in 1 month, and 274 in 1 year
           Nabet, Julien made 56 review comments in 1 month, and 772 in 1 year
           Heiko Tietze made 56 review comments in 1 month, and 266 in 1 year
           Kaganski, Mike made 52 review comments in 1 month, and 454 in 1 year
           Hossein made 52 review comments in 1 month, and 276 in 1 year
     + Patches automatically abandoned:
         vcl: move lcl_ShortenLastLinewithEndEllipsis() into TextLayoutHelper ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140441
         vcl: move lcl_GetMultilineLastLine() into TextLayoutHelper ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140442
         vcl: use clang-format on textlayout.[hc]xx ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140443
         vcl: migrate sfx2's ImplCalcActionBounds() to vcl ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140559
         vcl: move svtool's lcl_GetRulerTextGlyphs() to GetRulerTextGlyphs() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140560
         vcl: extract local functions from ImplLayout ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140563
         Related: tdf#151170  correction to switch for Slide and Page pane ( Seth Chaiklin )
             - https://gerrit.libreoffice.org/#/c/140604
         vcl: extract functions from GetTextLines() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140665
         vcl: migrate TextLayoutHelper::GetTextLines() to ImplMultiTextLineInfo ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140666
         vcl: extract functions from DrawMultilineText() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140667
         vcl: simplify code ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140668
         vcl: test generating ellipsises ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140694
         vcl: test generating an end ellipsis ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140695
         vcl: test NewsEllipsis ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140696
         vcl: extract functions from TextLayoutHelper::GetEllipsisString ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140725
         vcl: extract lcl_GetLastSectionIndex() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140752
         vcl: extract lcl_TextOverflows() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140774
         vcl: extract lcl_GetFirstSectionIndex() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140775
         vcl: extract lcl_ElideText() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140776
         vcl: extract lcl_ElideText() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140777
         vcl: extract lcl_ElideMiddleText() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140778
         vcl: simplify TextLayoutHelper::GetLastLine() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140779
         vcl: simplify TextLayoutHelper::GetEllipsisString() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140780
         vcl: test TextLayoutHelper::ShortenLastLineWithEllipsis() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140781
         vcl: remove GetLastLine() from ITextLayout ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140784
         vcl: split local functions ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140833
         vcl: rename to lcl_GetSingleLineMaxWidth() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140834
         vcl: clarify variable names ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140835
         vcl: add in missing unit test for GetTextRect() when style is VCenter. ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140854
         vcl: introduce CanRecodeString() and RecodeString() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140912
* Mentoring (Hossein)
   + Software Freedom Camp 2022
     + https://camp.fsci.in/projects/
   + New draft blog post (please give opinion/advise)
     UNO data types in LibreOffice API/code
     https://dev.blog.documentfoundation.org/?p=119&preview=1&_ppp=f8d418ce8e
   + Outreachy (Ilmari)
      + internship period started on Mon 5 Dec

* Commit Access
   + do we have a list of committers? (Caolan)
     + can export a list (Cloph)
     + also visible at https://gerrit.libreoffice.org/admin/groups/70c36bd1bfcbef2d3bcfc25622e8aaf57d99bb7c,members to committers
      + n = 430
   + if you cannot login to gerrit any more, clean cookies (Kendy)
     + auth.documentfoundation has moved (Cloph)
     + and write to hostmaster@ if problem persists

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 11 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
     from:Thu Dec  1 15:00:15 2022
     master linux rel  jobs: 165 ok:  98 ko:  67 fail ratio: 40.61 % break:  13 broken duration:10.19%
     master linux dbg  jobs: 107 ok:  33 ko:  73 fail ratio: 68.22 % break:   7 broken duration:63.41%
     master mac rel    jobs:  76 ok:  72 ko:   4 fail ratio:  5.26 % break:   1 broken duration: 0.92%
     master mac dbg    jobs:  79 ok:  75 ko:   4 fail ratio:  5.06 % break:   1 broken duration: 0.92%
     master win rel    jobs:  68 ok:  64 ko:   4 fail ratio:  5.88 % break:   2 broken duration: 1.13%
     master win dbg    jobs:  78 ok:  75 ko:   3 fail ratio:  3.85 % break:   1 broken duration: 0.91%
     master win64 dbg  jobs:  73 ok:  70 ko:   3 fail ratio:  4.11 % break:   1 broken duration: 0.93%
     master gerrit lin jobs: 473 ok: 356 ko:  94 fail ratio: 19.87% time for ok: mean:  23 median:  19
     master gerrit plg jobs: 428 ok: 270 ko: 131 fail ratio: 30.61% time for ok: mean:  53 median:  51
     master gerrit win jobs: 459 ok: 324 ko:  84 fail ratio: 18.30% time for ok: mean:  61 median:  58
     master gerrit mac jobs: 453 ok: 320 ko:  83 fail ratio: 18.32% time for ok: mean:  38 median:  33
     master android    jobs: 411 ok: 350 ko:  33 fail ratio:  8.03% time for ok: mean:  24 median:  17
     master gerrit all jobs: 442 ok: 215 ko: 165 fail ratio: 37.33% time for ok: mean:  84 median:  68
    + https://dev-www.libreoffice.org/tmp/gerrit_221208.html
    + tests that failed more than twice in last seven days
       3 CppunitTest_oox_export                gerrit_windows
       3 CppunitTest_sw_mailmerge2                gerrit_windows
       3 UITest_librelogo                gerrit_linux_clang_dbgutil
       3 UITest_writer_tests6                gerrit_linux_clang_dbgutil
       5 CppunitTest_sw_mailmerge                gerrit_windows
       6 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
   + builds were OK, but jenkins itself had memory issues, had to restart a few times (Cloph)

* decommission of tinderbox.libreoffice.org (cloph)
   + duplicates what is on jenkins, no standalone tinderboxes anymore
   + there will be redirects to Jenkins with some kind of dashboard view
   → any objections?
   => no, go ahead (all)

* FOSDEM 2023 (Xisco)
   + 11th December is the deadline to submit talks:
   + submissions via pentabarf:  https://penta.fosdem.org/submission/FOSDEM23
   + please submit your talks (if you're coming) this week
   + details: https://blog.documentfoundation.org/blog/2022/11/08/fosdem-2023-cfp-libreoffice-technology-devroom/
    + Team/TDF members who are going: Italo is looking for hotel reservations
    + Dev room will be in-person only (Thorsten)
      + "FOSDEM 2023 will be in person, taking place on Saturday, February 4, and Sunday, February 5."
      + Maybe an additional virtual event, but definitely not at the same time
        + Any interest in that?
           Hossein can't attend in-person
        + Thorsten will poke Italo
          + if you plan to present virtually, mention it in the talk proposal! (Hossein)
    + Caolan: submitted a talk
    + Cloph: plan to submit a talk
    + Heiko: will attend, not sure about talking
    + Hossein: will file a talk if can present virtually

      + Ilmari, Kendy, Eike, Michael S: can't come this time

    + Xisco: attending, will submit one
    + Gabriel: will attend, probably no talk plans
    + Stephan: not sure yet
    + Stéphane: plan to come, will submit one
    + Miklos: plan to attend, will submit a content control talk
    + will there be a hackfest after FOSDEM? (Xisco)
      + there are *plans* after FOSDEM (February 6/7)(Cloph)
        https://lists.freedesktop.org/archives/libreoffice/2022-November/089651.html

* What’s cooking (Miklos)

* QA update (Xisco)
     + UNCONFIRMED: 1680 (-30)
         + enhancements: 285  (+2)
         + needsUXEval: 4 (+1)
         + haveBackTrace: 8 (+1)
         + needsDevAdvice: 32 (+1)
         + documentation:  15 (+1)
         + android:  3 (+0)
         + iOS:  0 (+0)
         + Online:  11 (+0)

     + Most pressing bugs:
      None

     + New high severity bugs of the week:

     None


* QA stats (Stephane)
      + Progressing on reviewing 7.5 release notes, including with keyword "inReleaseNotes:7.5"
      + looking at enhancements which are not tagged as "in release notes"
      + thanks Caolan to all the gtk3 fixes recently found

       + If you are interested, potential macOS + VoiceOver crash: https://bugs.documentfoundation.org/show_bug.cgi?id=152395

         + needs confirming

     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +100  +26 (-154) overall)
       many thanks to the top bug squashers:
        QA Administrators       37
        Buovjaga                17
        Stéphane Guillou (stragu) 12
        Caolán McNamara         11
        خالد حسني               11
        Mike Kaganski           6
        V Stuart Foote          6
        Heiko Tietze            5
        Rafael Lima             5
        Noel Grandin            4

     + top 10 bugs reporters:
        Mike Kaganski           8
        Stéphane Guillou (stragu) 6
        Robert Großkopf         3
        emu                     3
        steve                   3
        Rafael Lima             2
        Regina Henschel         2
        Robert Ombuzal          2
        dhina                   2
        Daniel T.               1

     + top 10 bugs fixers:
        McNamara, Caolán        11
        Kaganski, Mike          5
        Rafael Lima             4
        Grandin, Noel           3
        Heiko Tietze            3
        Stéphane Guillou (stragu) 3
        Adolfo Jayme Barrientos 2
        Tünde Tóth              2
        خالد حسني               2
                                1

     + top 10 bugs confirmers:
        Ilmari Lauhakangas      19
        *UNKNOWN*               13
        Stéphane Guillou (stragu) 13
        Dieter                  9
        m.a.riosv               7
        Heiko Tietze            6
        خالد حسني               5
        McNamara, Caolán        4
        Telesto                 3
        Nabet, Julien           2

* Highest-Priority bugs (aka "MABs"):
    + http://bit.ly/2lJAAJI
      6.0 : 1/53 -     1 %  (+0)
      5.4 : 0/41 -     0 %  (+0)
      5.3 : 0/54 -     0 %  (+0)
      5.2 : 0/43 -     0 %  (+0)
      5.1 : 0/35 -     0 %  (+0)
      5.0 : 0/64 -     0 %  (+0)
      4.4 : 0/76 -     0 %  (+0)
      4.3 : 0/73 -     0 %  (+0)
      4.2 : 2/134 -    1 %  (+0)
      4.1 : 2/85 -     2 %  (+0)
      4.0 : 1/83 -     1 %  (+0)
      old : 1/246 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Stéphane Guillou (stragu)   3
         Raal                        2
         Ilmari Lauhakangas          1

* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Stéphane Guillou (stragu)   3
         Raal                        2
         Ilmari Lauhakangas          1

* all bugs tagged with 'regression'
    + 1195(+1) bugs open of 12172(+12) total 8(+0) high prio.

      done by:
         Stéphane Guillou (stragu)   3
         Ilmari Lauhakangas          1
         Neko-san                    1
         Raal                        1
         Henschel, Regina            1
         Robert Großkopf             1
         Telesto                     1

* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 5(+0)
      Calc          - 1(+0)
      Draw          - 1(+0)
      LibreOffice   - 1(+0)

    by OS:
      All           - 7(+0)
      Linux         - 0(+0)
      Mac OS X      - 0(+0)
      Windows       - 1(+0)

* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 426(+2)
      Calc                     - 204(+1)
      Impress                  - 117(+0)
      Writer: docx filter      - 58(+0)
      Crashes                  - 54(+1)
      LibreOffice              - 44(-1)
      Base                     - 41(+0)
      Draw                     - 40(+0)
      UI                       - 36(+0)
      Writer: perf             - 35(-1)
      Borders                  - 31(+0)
      Writer: other filter     - 29(+0)
      Chart                    - 24(-1)
      RTL                      - 23(+0)
      Writer: doc filter       - 19(+0)
      BASIC                    - 18(+1)
      Printing and PDF export  - 16(+1)
      filters and storage      - 15(+0)
      graphics stack           - 14(+0)
      Formula Editor           - 4(+0)
      sdk                      - 2(+0)
      framework                - 1(+0)


More information about the LibreOffice mailing list