New Defects reported by Coverity Scan for LibreOffice
scan-admin at coverity.com
scan-admin at coverity.com
Sun Jun 11 19:07:11 UTC 2023
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
6 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1532370: Uninitialized variables (UNINIT)
________________________________________________________________________________________________________
*** CID 1532370: Uninitialized variables (UNINIT)
/svx/source/theme/ThemeColorPaletteManager.cxx: 127 in svx::ThemeColorPaletteManager::generate()()
121 {
122 aColorName = aColorNames[nColor];
123 }
124 rEffect.maColorName = aColorName;
125 }
126 }
>>> CID 1532370: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aThemePaletteCollection.maColors._M_elems[0].meThemeColorType" when calling "ThemePaletteCollection".
127 return aThemePaletteCollection;
128 }
129
130 OString ThemeColorPaletteManager::generateJSON()
131 {
132 svx::ThemePaletteCollection aThemePaletteCollection = generate();
** CID 1532369: Null pointer dereferences (FORWARD_NULL)
/sc/source/filter/oox/commentsbuffer.cxx: 170 in oox::xls::Comment::finalizeImport()()
________________________________________________________________________________________________________
*** CID 1532369: Null pointer dereferences (FORWARD_NULL)
/sc/source/filter/oox/commentsbuffer.cxx: 170 in oox::xls::Comment::finalizeImport()()
164 SdrCaptionObj* pCaption = pPostIt->GetOrCreateCaption( maModel.maRange.aStart );
165
166 rtl::Reference< SvxShapeText > xAnnoShape( dynamic_cast<SvxShapeText*>(pCaption->getUnoShape().get() ) ); // SvxShapeText
167 // setting a property triggers expensive process, so set them all at once
168
169 // Add shape formatting properties (autoFill, colHidden and rowHidden are dropped)
>>> CID 1532369: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "xAnnoShape.get()" to "setPropertyValues", which dereferences it. (The dereference happens because this is a virtual function call.)
170 static_cast<SvxShape*>(xAnnoShape.get())->setPropertyValues(
171 Sequence<OUString> { "TextFitToSize", "MoveProtect", "TextHorizontalAdjust", "TextVerticalAdjust" },
172 Sequence<Any> { Any(maModel.mbAutoScale), Any(maModel.mbLocked),
173 Any(lcl_ToHorizAlign( maModel.mnTHA )), Any(lcl_ToVertAlign( maModel.mnTVA )) });
174 if( maModel.maAnchor.Width > 0 && maModel.maAnchor.Height > 0 )
175 {
** CID 1532368: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 1532368: Null pointer dereferences (FORWARD_NULL)
/svgio/source/svgreader/svgfilternode.cxx: 49 in svgio::svgreader::SvgFilterNode::apply(drawinglayer::primitive2d::Primitive2DContainer &) const()
43 {
44 SvgNode* pCandidate = rChildren[a].get();
45 if (pCandidate->getType() == SVGToken::FeGaussianBlur)
46 {
47 const SvgFeGaussianBlurNode* pFeGaussianBlurNode
48 = dynamic_cast<const SvgFeGaussianBlurNode*>(pCandidate);
>>> CID 1532368: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pFeGaussianBlurNode" to "apply", which dereferences it.
49 pFeGaussianBlurNode->apply(rTarget);
50 }
51 else if (pCandidate->getType() == SVGToken::FeColorMatrix)
52 {
53 const SvgFeColorMatrixNode* pFeColorMatrixNode
54 = dynamic_cast<const SvgFeColorMatrixNode*>(pCandidate);
** CID 1532367: (UNUSED_VALUE)
/sw/source/uibase/misc/redlndlg.cxx: 887 in SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
/sw/source/uibase/misc/redlndlg.cxx: 892 in SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
________________________________________________________________________________________________________
*** CID 1532367: (UNUSED_VALUE)
/sw/source/uibase/misc/redlndlg.cxx: 887 in SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
881 }
882 }
883 else
884 {
885 // redline is not in a tracked table change
886 bChange = bRowChange = false;
>>> CID 1532367: (UNUSED_VALUE)
>>> Assigning value "2147483647UL" to "nPrevRowChange" here, but that stored value is overwritten before it can be used.
887 nPrevRowChange = SwRedlineTable::npos;
888 }
889 }
890 else
891 // redline is not in a tracked table change
892 nPrevRowChange = SwRedlineTable::npos;
/sw/source/uibase/misc/redlndlg.cxx: 892 in SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
886 bChange = bRowChange = false;
887 nPrevRowChange = SwRedlineTable::npos;
888 }
889 }
890 else
891 // redline is not in a tracked table change
>>> CID 1532367: (UNUSED_VALUE)
>>> Assigning value "2147483647UL" to "nPrevRowChange" here, but that stored value is overwritten before it can be used.
892 nPrevRowChange = SwRedlineTable::npos;
893
894 bool bShowDeletedTextAsComment = bIsShowChangesInMargin &&
895 RedlineType::Delete == rRedln.GetType() && rRedln.GetComment().isEmpty();
896 const OUString& sComment = bShowDeletedTextAsComment
897 ? const_cast<SwRangeRedline&>(rRedln).GetDescr()
** CID 1532366: Uninitialized variables (UNINIT)
________________________________________________________________________________________________________
*** CID 1532366: Uninitialized variables (UNINIT)
/sc/source/ui/view/output.cxx: 2599 in ScOutputData::AddPDFNotes()()
2593 OUString aContent = pNote->GetText();
2594 aContent = aContent.replaceAll("\n", " ");
2595
2596 vcl::PDFNote aNote;
2597 aNote.Title = aTitle;
2598 aNote.Contents = aContent;
>>> CID 1532366: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aNote". Field "aNote.isFreeText" is uninitialized when calling "CreateNote".
2599 pPDFData->CreateNote( aNoteRect, aNote );
2600 }
2601 }
2602
2603 nPosX += pRowInfo[0].basicCellInfo(nX).nWidth * nLayoutSign;
2604 }
** CID 1532365: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 1532365: Null pointer dereferences (FORWARD_NULL)
/svgio/source/svgreader/svgfilternode.cxx: 55 in svgio::svgreader::SvgFilterNode::apply(drawinglayer::primitive2d::Primitive2DContainer &) const()
49 pFeGaussianBlurNode->apply(rTarget);
50 }
51 else if (pCandidate->getType() == SVGToken::FeColorMatrix)
52 {
53 const SvgFeColorMatrixNode* pFeColorMatrixNode
54 = dynamic_cast<const SvgFeColorMatrixNode*>(pCandidate);
>>> CID 1532365: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pFeColorMatrixNode" to "apply", which dereferences it.
55 pFeColorMatrixNode->apply(rTarget);
56 }
57 }
58 }
59
60 } // end of namespace svgio::svgreader
61
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DxqPf_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJil2KJYohgYODNrHNZ-2B8IL-2F8ubs2-2Fqfi9ajjgOVlX-2BVExI0SDdp10EJnSQsG4ZnCyzHEfiV3HuvYwG8Eu1C58LI8HGmsXsfvx93gBUYTvz120ngK1EeXCP-2BIeVJOxQzrZAIB-2FAlZl9sZyiT3sc4ozMxB7j2kJOpYh1KC-2B880F9qfg-3D
More information about the LibreOffice
mailing list