New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1521854:  Error handling issues  (CHECKED_RETURN)
/sw/source/uibase/uiview/view2.cxx: 1246 in SwView::Execute(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1521854:  Error handling issues  (CHECKED_RETURN)
/sw/source/uibase/uiview/view2.cxx: 1246 in SwView::Execute(SfxRequest &)()
1240                         ;   // jump to the first "table of ..."
1241     
1242                     // if we are not in one, jump to next
1243                     const SwTOXBase* pBase = m_pWrtShell->GetCurTOX();
1244                     if( !pBase )
1245                     {
>>>     CID 1521854:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "GotoNextTOXBase" without checking return value (as is done elsewhere 4 out of 5 times).
1246                         m_pWrtShell->GotoNextTOXBase();
1247                         pBase = m_pWrtShell->GetCurTOX();
1248                     }
1249     
1250                     bool bAutoMarkApplied = false;
1251                     while( pBase )

** CID 1521853:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1521853:  Uninitialized variables  (UNINIT)
/cui/source/options/optasian.cxx: 367 in SvxAsianLayoutPage::ModifyHdl(weld::Entry &)()
361                     ForbiddenCharacters aFCSet;
362                     aFCSet.beginLine = sStart;
363                     aFCSet.endLine = sEnd;
364                     pImpl->addForbiddenCharacters(eSelectLanguage, std::move(aFCSet));
365                 }
366                 else
>>>     CID 1521853:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "<temporary>._M_payload._M_payload" when calling "~optional".
367                     pImpl->addForbiddenCharacters(eSelectLanguage, std::nullopt);
368             }
369             catch (const Exception&)
370             {
371                 TOOLS_WARN_EXCEPTION( "cui.options", "in XForbiddenCharacters");
372             }

** CID 1521852:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1521852:  Null pointer dereferences  (FORWARD_NULL)
/vcl/jsdialog/executor.cxx: 146 in jsdialog::ExecuteAction(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, const rtl::OString &, std::map<rtl::OUString, rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<const rtl::OUString, rtl::OUString>>> &)()
140                     {
141                         pButton->clicked();
142                         return true;
143                     }
144                     else if (sAction == "toggle")
145                     {
>>>     CID 1521852:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "dynamic_cast <weld::Toggleable *>(pWidget)" to "trigger_toggled", which dereferences it.
146                         LOKTrigger::trigger_toggled(*dynamic_cast<weld::Toggleable*>(pWidget));
147                         return true;
148                     }
149                 }
150             }
151             else if (sControlType == "menubutton")


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DjCu0_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiJjIfpRKja2R9rWLkDbVkuuALwK3za-2BNoNmpyR4jEykXI7Fl-2FEIW0axxEqXiT8bmWsYqLOUyds-2BxIBIbJf6jKLAJbUAwE7SiAM-2BzuVsPjk8gF4TOfcxP4mogtifUnR31HXU4-2FVIO4Iuu-2FpZvQtF1aBGMCbvzd-2B5-2FNCOlxr-2Bds95c-3D