New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1521901:    (RETURN_LOCAL)
/package/source/zipapi/ZipFile.cxx: 1126 in ZipFile::recover()()
/package/source/zipapi/ZipFile.cxx: 1126 in ZipFile::recover()()


________________________________________________________________________________________________________
*** CID 1521901:    (RETURN_LOCAL)
/package/source/zipapi/ZipFile.cxx: 1126 in ZipFile::recover()()
1120                                         {
1121                                             Sequence<sal_Int8> aExtraFields;
1122                                             aGrabber.seek(nGenPos + nPos + 30 + aEntry.nExtraLen);
1123                                             aGrabber.readBytes(aExtraFields, aEntry.nExtraLen);
1124                                             aExtraBuffer = &aExtraFields;
1125                                         }
>>>     CID 1521901:    (RETURN_LOCAL)
>>>     Using "aExtraBuffer", which points to an out-of-scope variable "aExtraFields".
1126                                         MemoryByteGrabber aMemGrabberExtra(*aExtraBuffer);
1127                                         if (aEntry.nExtraLen > 0)
1128                                         {
1129                                             readExtraFields(aMemGrabberExtra, aEntry.nExtraLen, nSize,
1130                                                             nCompressedSize, nullptr);
1131                                         }
/package/source/zipapi/ZipFile.cxx: 1126 in ZipFile::recover()()
1120                                         {
1121                                             Sequence<sal_Int8> aExtraFields;
1122                                             aGrabber.seek(nGenPos + nPos + 30 + aEntry.nExtraLen);
1123                                             aGrabber.readBytes(aExtraFields, aEntry.nExtraLen);
1124                                             aExtraBuffer = &aExtraFields;
1125                                         }
>>>     CID 1521901:    (RETURN_LOCAL)
>>>     Using "aExtraBuffer", which points to an out-of-scope variable "aTmpBuffer2".
1126                                         MemoryByteGrabber aMemGrabberExtra(*aExtraBuffer);
1127                                         if (aEntry.nExtraLen > 0)
1128                                         {
1129                                             readExtraFields(aMemGrabberExtra, aEntry.nExtraLen, nSize,
1130                                                             nCompressedSize, nullptr);
1131                                         }

** CID 1521900:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1521900:  Uninitialized variables  (UNINIT)
/sc/source/core/data/documen2.cxx: 1038 in ScDocument::TransferTab(ScDocument&, short, short, bool, bool)()
1032             }
1033     
1034             if (auto aRepeatRowRange = rSrcDoc.maTabs[nSrcPos]->GetRepeatRowRange())
1035             {
1036                 aRepeatRowRange->aStart.SetTab(nDestPos);
1037                 aRepeatRowRange->aEnd.SetTab(nDestPos);
>>>     CID 1521900:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "aRepeatRowRange". Field "aRepeatRowRange._M_payload._M_payload" is uninitialized when calling "optional".
1038                 maTabs[nDestPos]->SetRepeatRowRange(aRepeatRowRange);
1039             }
1040     
1041             if (rSrcDoc.IsPrintEntireSheet(nSrcPos))
1042                 maTabs[nDestPos]->SetPrintEntireSheet();
1043             else

** CID 1521899:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1521899:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/text/widorp.cxx: 531 in WidowsAndOrphans::FindWidows(SwTextFrame *, SwTextMargin &)()
525                 const SwFrame* pRow = pFrame;
526                 while (pRow && !pRow->IsRowFrame())
527                 {
528                     pRow = pRow->GetUpper();
529                 }
530     
>>>     CID 1521899:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pRow" to "HasFixSize", which dereferences it.
531                 if (pRow->HasFixSize())
532                 {
533                     // This is a follow frame and our side is fixed.
534                     const SwAttrSet& rSet = pFrame->GetTextNodeForParaProps()->GetSwAttrSet();
535                     const SvxOrphansItem& rOrph = rSet.GetOrphans();
536                     if (nLines <= rOrph.GetValue())

** CID 1521898:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1521898:  Uninitialized variables  (UNINIT)
/sc/source/core/data/documen2.cxx: 1031 in ScDocument::TransferTab(ScDocument&, short, short, bool, bool)()
1025     
1026             // tdf#66613 - copy existing print ranges and col/row repetitions
1027             if (auto aRepeatColRange = rSrcDoc.maTabs[nSrcPos]->GetRepeatColRange())
1028             {
1029                 aRepeatColRange->aStart.SetTab(nDestPos);
1030                 aRepeatColRange->aEnd.SetTab(nDestPos);
>>>     CID 1521898:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "aRepeatColRange". Field "aRepeatColRange._M_payload._M_payload" is uninitialized when calling "optional".
1031                 maTabs[nDestPos]->SetRepeatColRange(aRepeatColRange);
1032             }
1033     
1034             if (auto aRepeatRowRange = rSrcDoc.maTabs[nSrcPos]->GetRepeatRowRange())
1035             {
1036                 aRepeatRowRange->aStart.SetTab(nDestPos);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DGRAh_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi4nQZnlPxzpHSv-2FbkaIs0N9BlZpbTEWp8Q01JJonCPYmstbD2ZMvg5APO1WvWThmsjjdmrgYwINw-2BE2xPYI-2BO3Rw4-2B2Z7-2FNmTmhxjEQI6fw8ADFewBC4WsLoNyuO8ZXBgjkXHaHAUKotBP4iO0qdUxtdAn-2Bv6x6uXB83up3fqMaY-3D