New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
17 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1591747:  Control flow issues  (NO_EFFECT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode &)()


________________________________________________________________________________________________________
*** CID 1591747:  Control flow issues  (NO_EFFECT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode &)()
456         mrStream.ReadUInt16(nUnit);
457         readPoint(aOrigin);
458         readFraction(aScaleX);
459         readFraction(aScaleY);
460         mrStream.ReadCharAsBool(bSimple);
461     
>>>     CID 1591747:  Control flow issues  (NO_EFFECT)
>>>     This less-than-zero comparison of an unsigned value is never true. "nUnit < 0".
462         if (nUnit < sal_Int16(MapUnit::Map100thMM) || nUnit > sal_Int16(MapUnit::LAST))
463         {
464             SAL_WARN("vcl.gdi", "Parsing error: invalid mapmode");
465             return false;
466         }
467         MapUnit eUnit = static_cast<MapUnit>(nUnit);

** CID 1591746:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode &)()


________________________________________________________________________________________________________
*** CID 1591746:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode &)()
456         mrStream.ReadUInt16(nUnit);
457         readPoint(aOrigin);
458         readFraction(aScaleX);
459         readFraction(aScaleY);
460         mrStream.ReadCharAsBool(bSimple);
461     
>>>     CID 1591746:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "nUnit < 0 /* (sal_Int16)MapUnit::Map100thMM */" is always false regardless of the values of its operands. This occurs as the logical first operand of "||".
462         if (nUnit < sal_Int16(MapUnit::Map100thMM) || nUnit > sal_Int16(MapUnit::LAST))
463         {
464             SAL_WARN("vcl.gdi", "Parsing error: invalid mapmode");
465             return false;
466         }
467         MapUnit eUnit = static_cast<MapUnit>(nUnit);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3Doo0P_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiKCkzfyxoeQcM5wzPHNpnNYhnHmuGI4YO-2F0xdfF3oWcgfgZvFMXwuWwfCIx8UMZO-2FdAC6eMLXLjm7BlypTHmZBivbagamiEGfFLi6PCP7GFfa5WThz1S5xy4ZmSGUU-2BjF-2FbaluI7tI-2BGbfL14bTYl2rqqtG4SlApvqwwD2UjYE2Y-3D