master build broken on macOS due to Firebird update

[Patrick Luby]

So I used the attached debug patch and now I am only runnning into 
casting errors. Still more work to do, but at least it is progress.

I'll see how far I can get patching the errors.

Patrick


On 2024-01-06 11:22 a.m., Regina Henschel wrote:
> Hi all,
> 
> it breaks for me too. VS2022 on Win11 with --enable-dbgutil. So not only 
> macOS.
> 
> Kind regards,
> Regina
> 
> Patrick Luby schrieb am 06.01.2024 um 16:20:
>> All,
>>
>> I am not sure how this update built successfully on macOS on Jenkins, 
>> but the Firebird update is filled with hundreds of sprintf calls like 
>> the following. Xcode has marked sprintf as deprecated since a couple 
>> of versions ago:
>>
>> /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/temp/Debug/isql/show.cpp:6986:5: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
>>                                  sprintf(info, "Number of DB pages 
>> free = %" SQUADFORMAT"%s", value_out, separator);
>>
>> So how do we suppress these "en masse" when doing debug builds?
>>
>> Thanks,
>>
>> Patrick
>>
> 
-------------- next part --------------
diff --git a/external/firebird/ExternalProject_firebird.mk b/external/firebird/ExternalProject_firebird.mk
index 5b39fd82b1e3..5556f9d1ae82 100644
--- a/external/firebird/ExternalProject_firebird.mk
+++ b/external/firebird/ExternalProject_firebird.mk
@@ -57,7 +57,7 @@ $(call gb_ExternalProject_get_state_target,firebird,build):
 			$(if $(filter MSC-TRUE-X86_64,$(COM)-$(COM_IS_CLANG)-$(CPUNAME)),-march=x86-64-v2) \
 			$(if $(HAVE_GCC_FNO_SIZED_DEALLOCATION),-fno-sized-deallocation -fno-delete-null-pointer-checks) \
 			$(CXXFLAGS_CXX11) \
-			$(if $(filter TRUE,$(COM_IS_CLANG)), -Wno-c++11-narrowing) \
+			$(if $(filter TRUE,$(COM_IS_CLANG)), -Wno-error) \
 			$(call gb_ExternalProject_get_build_flags,firebird) \
 			$(if $(ENABLE_DEBUG),$(if $(filter MSC,$(COM)),-Od -Z7)) \
 		" \