master build broken on macOS due to Firebird update

[Patrick Luby]

I have submitted a revert for the Firebird update here:

https://gerrit.libreoffice.org/c/core/+/161683

There are still errors even when I build a non-debug build. So, the only 
way I can see this update sucessfully building on macOS is that Jenkins 
builds Mac Intel targeting an older (pre-Ventura) version of macos i.e. 
before Apple deprecated sprintf.

IMHO, the Firebird update needs a lot more work before recommitting it.

Patrick

On 2024-01-06 11:36 a.m., Patrick Luby wrote:
> 
> So I used the attached debug patch and now I am only runnning into 
> casting errors. Still more work to do, but at least it is progress.
> 
> I'll see how far I can get patching the errors.
> 
> Patrick
> 
> 
> On 2024-01-06 11:22 a.m., Regina Henschel wrote:
>> Hi all,
>>
>> it breaks for me too. VS2022 on Win11 with --enable-dbgutil. So not 
>> only macOS.
>>
>> Kind regards,
>> Regina
>>
>> Patrick Luby schrieb am 06.01.2024 um 16:20:
>>> All,
>>>
>>> I am not sure how this update built successfully on macOS on Jenkins, 
>>> but the Firebird update is filled with hundreds of sprintf calls like 
>>> the following. Xcode has marked sprintf as deprecated since a couple 
>>> of versions ago:
>>>
>>> /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/temp/Debug/isql/show.cpp:6986:5: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
>>>                                  sprintf(info, "Number of DB pages 
>>> free = %" SQUADFORMAT"%s", value_out, separator);
>>>
>>> So how do we suppress these "en masse" when doing debug builds?
>>>
>>> Thanks,
>>>
>>> Patrick
>>>
>>