New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1634372:  Concurrent data access violations  (MISSING_LOCK)
/framework/source/uielement/recentfilesmenucontroller.cxx: 171 in <unnamed>::RecentFilesMenuController::fillPopupMenu(std::unique_lock<std::mutex> &, const com::sun::star::uno::Reference<com::sun::star::awt::XPopupMenu> &)()


________________________________________________________________________________________________________
*** CID 1634372:  Concurrent data access violations  (MISSING_LOCK)
/framework/source/uielement/recentfilesmenucontroller.cxx: 171 in <unnamed>::RecentFilesMenuController::fillPopupMenu(std::unique_lock<std::mutex> &, const com::sun::star::uno::Reference<com::sun::star::awt::XPopupMenu> &)()
165         // list should show only files that can be handled by the current module
166         const bool bShowCurrentModuleOnly
167             = officecfg::Office::Common::History::ShowCurrentModuleOnly::get();
168     
169         size_t nItemPosModule = 0;
170         size_t nItemPosPinned = 0;
>>>     CID 1634372:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->m_bDisabled" without holding lock "comphelper::UnoImplBase.m_aMutex". Elsewhere, "<unnamed>::RecentFilesMenuController.m_bDisabled" is written to with "UnoImplBase.m_aMutex" held 1 out of 1 times (1 of these accesses strongly imply that it is necessary).
171         if (( nPickListMenuItems > 0 ) && !m_bDisabled )
172         {
173             size_t nItemPos = 0;
174     
175             // tdf#155699 - create a lambda to insert a recent document item at a specified position
176             auto insertHistoryItemAtPos =


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DfcF1_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt20bp9GVU5Zm3l-2FQE3Kwddw2gI38DnQjHDHr7ryPpL5BAFfi6oiNEHcEbOK2UdN1RECzNVoWNP0s34vQLGarnQiwvwDdXmK69dIsXZ091S0UNIqjpJuCvqQsJitr7HVTSLkX-2F2nSfwmg1ODOoztPUNCHu6RhzWY4jGGQfsLo1n3s-3D