New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1634477:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 263 in oox::xls::Connection::importTextPr(const oox::AttributeList &)()


________________________________________________________________________________________________________
*** CID 1634477:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 263 in oox::xls::Connection::importTextPr(const oox::AttributeList &)()
257     {
258         TextPrModel& rTextPr = maModel.createTextPr();
259     
260         if (auto xFastAttributeList = rAttribs.getFastAttributeList())
261         {
262             css::uno::Sequence<css::uno::Any> aTextPrAny = getSequenceOfAny(xFastAttributeList);
>>>     CID 1634477:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aTextPrAny" is copied in a call to copy assignment "operator =", when it could be moved instead.
263             rTextPr.maTextPrSequenceAny = aTextPrAny;
264         }
265     }
266     
267     void Connection::importTextFields(const AttributeList& rAttribs)
268     {

** CID 1634476:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 218 in oox::xls::Connection::importOlapPr(const oox::AttributeList &)()


________________________________________________________________________________________________________
*** CID 1634476:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 218 in oox::xls::Connection::importOlapPr(const oox::AttributeList &)()
212     
213     void Connection::importOlapPr(const AttributeList& rAttribs)
214     {
215         if (auto xFastAttributeList = rAttribs.getFastAttributeList())
216         {
217             css::uno::Sequence<css::uno::Any> aOlapPrAny = getSequenceOfAny(xFastAttributeList);
>>>     CID 1634476:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aOlapPrAny" is copied in a call to copy assignment "operator =", when it could be moved instead.
218             maModel.maOlapPrSequenceAny = aOlapPrAny;
219         }
220     }
221     
222     void Connection::importTables(const AttributeList& rAttribs)
223     {

** CID 1634475:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 2534 in stringresource::StringResourceWithLocationImpl::implScanLocales(std::unique_lock<std::mutex> &)()


________________________________________________________________________________________________________
*** CID 1634475:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 2534 in stringresource::StringResourceWithLocationImpl::implScanLocales(std::unique_lock<std::mutex> &)()
2528     
2529     
2530     // Scan locale properties files
2531     void StringResourceWithLocationImpl::implScanLocales(std::unique_lock<std::mutex>& /*rGuard*/)
2532     {
2533         const Reference< ucb::XSimpleFileAccess3 > xFileAccess = getFileAccessImpl();
>>>     CID 1634475:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->m_aLocation" without holding lock "stringresource::StringResourceImpl.m_aMutex". Elsewhere, "stringresource::StringResourceWithLocationImpl.m_aLocation" is written to with "StringResourceImpl.m_aMutex" held 3 out of 3 times.
2534         if( xFileAccess->isFolder( m_aLocation ) )
2535         {
2536             Sequence< OUString > aContentSeq = xFileAccess->getFolderContents( m_aLocation, false );
2537             implScanLocaleNames( aContentSeq );
2538         }
2539     }

** CID 1634474:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 209 in oox::xls::Connection::importDbPr(const oox::AttributeList &)()


________________________________________________________________________________________________________
*** CID 1634474:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 209 in oox::xls::Connection::importDbPr(const oox::AttributeList &)()
203     
204     void Connection::importDbPr(const AttributeList& rAttribs)
205     {
206         if (auto xFastAttributeList = rAttribs.getFastAttributeList())
207         {
208             css::uno::Sequence<css::uno::Any> aDbPrAny = getSequenceOfAny(xFastAttributeList);
>>>     CID 1634474:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aDbPrAny" is copied in a call to copy assignment "operator =", when it could be moved instead.
209             maModel.maDbPrSequenceAny = aDbPrAny;
210         }
211     }
212     
213     void Connection::importOlapPr(const AttributeList& rAttribs)
214     {

** CID 1634473:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 278 in oox::xls::Connection::importTextFields(const oox::AttributeList &)()


________________________________________________________________________________________________________
*** CID 1634473:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sc/source/filter/oox/connectionsbuffer.cxx: 278 in oox::xls::Connection::importTextFields(const oox::AttributeList &)()
272                        "Connection::importTextFields - multiple calls");
273             maModel.mxTextPr->vTextField.clear();
274     
275             if (auto xFastAttributeList = rAttribs.getFastAttributeList())
276             {
277                 css::uno::Sequence<css::uno::Any> aTextFieldsAny = getSequenceOfAny(xFastAttributeList);
>>>     CID 1634473:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aTextFieldsAny" is copied in a call to copy assignment "operator =", when it could be moved instead.
278                 maModel.mxTextPr->maTextFieldsSequenceAny = aTextFieldsAny;
279             }
280         }
281     }
282     
283     void Connection::importTextField(const AttributeList& rAttribs)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DpZ2H_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtbcerv4zPWA-2FbKwpx706Ng8-2BnNzxLfjQVMnSFX2LEPTOLhqWM4JfeZ-2B2MM-2BoSzYjP1shjEjWsQL1LzSYnopHBu2uybTmtZAo3-2FHBMFURTgU15tsvkRAgFOb-2B8UDdSheXWYwNiulClE98hv9j-2BmRfu5nMfRRoD4mVIvjtCKet2U9A-3D