New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
103 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1634483:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 528 in stringresource::StringResourceImpl::implScanIdForNumber(const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1634483:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 528 in stringresource::StringResourceImpl::implScanIdForNumber(const rtl::OUString &)()
522             }
523             else
524                 break;
525         }
526     
527         if( m_nNextUniqueNumericId < nNumber + 1 )
>>>     CID 1634483:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->m_nNextUniqueNumericId" without holding lock "stringresource::StringResourceImpl.m_aMutex". Elsewhere, "stringresource::StringResourceImpl.m_nNextUniqueNumericId" is written to with "StringResourceImpl.m_aMutex" held 2 out of 3 times.
528             m_nNextUniqueNumericId = nNumber + 1;
529     }
530     
531     sal_Int32 StringResourceImpl::getUniqueNumericId(  )
532     {
533         std::unique_lock aGuard( m_aMutex );

** CID 1634482:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 2547 in stringresource::StringResourceWithLocationImpl::implLoadLocale(std::unique_lock<std::mutex> &, stringresource::LocaleItem *)()


________________________________________________________________________________________________________
*** CID 1634482:  Concurrent data access violations  (MISSING_LOCK)
/scripting/source/stringresource/stringresource.cxx: 2547 in stringresource::StringResourceWithLocationImpl::implLoadLocale(std::unique_lock<std::mutex> &, stringresource::LocaleItem *)()
2541     // Loading
2542     bool StringResourceWithLocationImpl::implLoadLocale(std::unique_lock<std::mutex>& /*rGuard*/, LocaleItem* pLocaleItem)
2543     {
2544         bool bSuccess = false;
2545     
2546         const Reference< ucb::XSimpleFileAccess3 > xFileAccess = getFileAccessImpl();
>>>     CID 1634482:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->m_aLocation" without holding lock "stringresource::StringResourceImpl.m_aMutex". Elsewhere, "stringresource::StringResourceWithLocationImpl.m_aLocation" is written to with "StringResourceImpl.m_aMutex" held 3 out of 3 times.
2547         OUString aCompleteFileName =
2548             implGetPathForLocaleItem( pLocaleItem, m_aNameBase, m_aLocation );
2549     
2550         Reference< io::XInputStream > xInputStream;
2551         try
2552         {

** CID 1634481:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/sw/source/uibase/sidebar/PageStylesPanel.cxx: 555 in sw::sidebar::PageStylesPanel::ModifyFillColor()()


________________________________________________________________________________________________________
*** CID 1634481:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/sw/source/uibase/sidebar/PageStylesPanel.cxx: 555 in sw::sidebar::PageStylesPanel::ModifyFillColor()()
549         const eFillStyle eXFS = static_cast<eFillStyle>(mxBgFillType->get_active());
550         SfxObjectShell* pSh = SfxObjectShell::Current();
551         switch(eXFS)
552         {
553             case SOLID:
554             {
>>>     CID 1634481:  Performance inefficiencies  (AUTO_CAUSES_COPY)
>>>     Using the "auto" keyword without an "&" causes the copy of an object of type "NamedColor".
555                 auto aNamedColor =  mxBgColorLB->GetSelectedEntry();
556                 XFillColorItem aItem(OUString(), aNamedColor.m_aColor);
557                 aItem.setComplexColor(aNamedColor.getComplexColor());
558                 aItem.setComplexColor(mxBgColorLB->GetSelectedEntry().getComplexColor());
559                 GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_COLOR, SfxCallMode::RECORD, { &aItem });
560             }

** CID 1634480:    (AUTO_CAUSES_COPY)
/cui/source/tabpages/chardlg.cxx: 2141 in SvxCharEffectsPage::FillItemSet(SfxItemSet *)()
/cui/source/tabpages/chardlg.cxx: 2102 in SvxCharEffectsPage::FillItemSet(SfxItemSet *)()


________________________________________________________________________________________________________
*** CID 1634480:    (AUTO_CAUSES_COPY)
/cui/source/tabpages/chardlg.cxx: 2141 in SvxCharEffectsPage::FillItemSet(SfxItemSet *)()
2135             }
2136         }
2137     
2138         if ( bChanged )
2139         {
2140             SvxOverlineItem aNewItem( eOver, nWhich );
>>>     CID 1634480:    (AUTO_CAUSES_COPY)
>>>     Using the "auto" keyword without an "&" causes the copy of an object of type "NamedColor".
2141             auto aNamedColor = m_xOverlineColorLB->GetSelectedEntry();
2142             aNewItem.SetColor(aNamedColor.m_aColor);
2143             aNewItem.setComplexColor(aNamedColor.getComplexColor());
2144             rSet->Put(aNewItem);
2145             bModified = true;
2146         }
/cui/source/tabpages/chardlg.cxx: 2102 in SvxCharEffectsPage::FillItemSet(SfxItemSet *)()
2096             }
2097         }
2098     
2099         if ( bChanged )
2100         {
2101             SvxUnderlineItem aNewItem( eUnder, nWhich );
>>>     CID 1634480:    (AUTO_CAUSES_COPY)
>>>     Using the "auto" keyword without an "&" causes the copy of an object of type "NamedColor".
2102             auto aNamedColor = m_xUnderlineColorLB->GetSelectedEntry();
2103             aNewItem.SetColor(aNamedColor.m_aColor);
2104             aNewItem.setComplexColor(aNamedColor.getComplexColor());
2105             rSet->Put(aNewItem);
2106             bModified = true;
2107         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DQYI5_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtrWPxQl02wTGUef2wkaY7zmNUrrmln5T-2BZ935XYOPezlVeLD19QhjyCdCKVtOAUphWPtNoHXOc5K-2FxGLVi3tEMu3mNHiixCBwpcjexuLQkJx1QPvp-2F6WCtaz2oMwDvEbd8xg5ldrXfOsfieCLd2A3NAV6sfn86HaoEOG6hMDWDQI-3D